You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/04/12 21:07:04 UTC

Review Request 58401: Fix misleading solr-client output messages

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert Nettleton.


Bugs: AMBARI-20751
    https://issues.apache.org/jira/browse/AMBARI-20751


Repository: ambari


Description
-------

In some cases, its possible collection creation is not working (e.g.: solr nodes cannot communicate with each other for some reason in ssl enabled environment). Therefore its possible, that the client say that collection has already created, but in fact that was not successful.


Diffs
-----

  ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java d5d971c 


Diff: https://reviews.apache.org/r/58401/diff/1/


Testing
-------

done.


Thanks,

Oliver Szabo


Re: Review Request 58401: Fix misleading solr-client output messages

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/#review171796
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On April 12, 2017, 9:07 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58401/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20751
>     https://issues.apache.org/jira/browse/AMBARI-20751
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In some cases, its possible collection creation is not working (e.g.: solr nodes cannot communicate with each other for some reason in ssl enabled environment). Therefore its possible, that the client say that collection has already created, but in fact that was not successful.
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java d5d971c 
> 
> 
> Diff: https://reviews.apache.org/r/58401/diff/1/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 58401: Fix misleading solr-client output messages

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/#review171810
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On April 12, 2017, 9:07 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58401/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20751
>     https://issues.apache.org/jira/browse/AMBARI-20751
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In some cases, its possible collection creation is not working (e.g.: solr nodes cannot communicate with each other for some reason in ssl enabled environment). Therefore its possible, that the client say that collection has already created, but in fact that was not successful.
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java d5d971c 
> 
> 
> Diff: https://reviews.apache.org/r/58401/diff/1/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 58401: Fix misleading solr-client output messages

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58401/#review171837
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Doroszlai


On April 12, 2017, 11:07 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58401/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 11:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20751
>     https://issues.apache.org/jira/browse/AMBARI-20751
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In some cases, its possible collection creation is not working (e.g.: solr nodes cannot communicate with each other for some reason in ssl enabled environment). Therefore its possible, that the client say that collection has already created, but in fact that was not successful.
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java d5d971c 
> 
> 
> Diff: https://reviews.apache.org/r/58401/diff/1/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>