You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "John Hjelmstad (JIRA)" <ji...@apache.org> on 2009/02/14 02:52:59 UTC

[jira] Created: (SHINDIG-916) Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).

Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).
-----------------------------------------------------------------------------------------------------

                 Key: SHINDIG-916
                 URL: https://issues.apache.org/jira/browse/SHINDIG-916
             Project: Shindig
          Issue Type: Improvement
          Components: Java
    Affects Versions: trunk
            Reporter: John Hjelmstad
            Priority: Minor


At present, HTMLContentRewriter/ProxyingLinkRewriter manually construct proxy URLs from a per-instance injected proxy base parameter.

Instead, it should construct proxy URLs in a manner equivalent to gadgets.io.getProxyUrl(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SHINDIG-916) Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).

Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Hjelmstad reassigned SHINDIG-916:
--------------------------------------

    Assignee: John Hjelmstad

> Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-916
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-916
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: trunk
>            Reporter: John Hjelmstad
>            Assignee: John Hjelmstad
>            Priority: Minor
>
> At present, HTMLContentRewriter/ProxyingLinkRewriter manually construct proxy URLs from a per-instance injected proxy base parameter.
> Instead, it should construct proxy URLs in a manner equivalent to gadgets.io.getProxyUrl(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-916) Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).

Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673455#action_12673455 ] 

John Hjelmstad commented on SHINDIG-916:
----------------------------------------

Sorry, disregard... I'd misread the code in a quick scan :) fp will be maintained.

> Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-916
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-916
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: trunk
>            Reporter: John Hjelmstad
>            Assignee: John Hjelmstad
>            Priority: Minor
>
> At present, HTMLContentRewriter/ProxyingLinkRewriter manually construct proxy URLs from a per-instance injected proxy base parameter.
> Instead, it should construct proxy URLs in a manner equivalent to gadgets.io.getProxyUrl(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-916) Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).

Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673454#action_12673454 ] 

John Hjelmstad commented on SHINDIG-916:
----------------------------------------

Issue: the fp=<fingerprint> parameter is supported by ProxyingLinkRewriter but not gadgets.io.getProxyUrl(...) for obvious reasons.

With the resolution of SHINDIG-852 this can be resolved by manually adding [?|&]fp=<fingerprint> to both chained and query-style proxy URLs. However, it doesn't appear that the fingerprint is used by the proxy's (to which the proxied content presumably points) code... except in an oddly implicit way to bust caching.

Is this needed?

> Proxy link rewriter should support container-specific proxy links (echoing gadgets.io.getProxyUrl()).
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-916
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-916
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: trunk
>            Reporter: John Hjelmstad
>            Assignee: John Hjelmstad
>            Priority: Minor
>
> At present, HTMLContentRewriter/ProxyingLinkRewriter manually construct proxy URLs from a per-instance injected proxy base parameter.
> Instead, it should construct proxy URLs in a manner equivalent to gadgets.io.getProxyUrl(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.