You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Vladimir Sitnikov <si...@gmail.com> on 2019/11/09 21:29:50 UTC
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
>Fix dependencies for pom generation and remove version
Why are the dependencies added?
They are not used by JMeter.
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Vladimir Sitnikov <si...@gmail.com>.
> For com.miglayout:miglayout-swing , isn't it missing ?
It is declared in "core":
https://github.com/apache/jmeter/blob/b0448c8cb3b70e7c3c58f84af926d0071a091f78/src/core/build.gradle.kts#L74
>- Is scope runtime in the poms correct ?
It is
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
Oh, it's ok I didn't add it , I was just misreading diff.
Since I had removed version , I thought I had added it.
One last point (it's not my day, so let me *drink **th**e chalice till t*
*he* *end*)* ,*for httpmime, if we don't add httpcore explicitely , version
4.4.10 will be used as it's the one that is transitively used*
(dependency:tree),* shouldn't we in this case explicitly add it to force
the right version ?
On Sat, Nov 9, 2019 at 11:52 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >Where ?
>
>
> https://github.com/apache/jmeter/blob/2cfdec9d50ddab4649b813c07724588a03371ef4/src/protocol/build.gradle.kts#L86
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Vladimir Sitnikov <si...@gmail.com>.
>Where ?
https://github.com/apache/jmeter/blob/2cfdec9d50ddab4649b813c07724588a03371ef4/src/protocol/build.gradle.kts#L86
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sat, Nov 9, 2019 at 11:48 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >1/ I reverted the ones that indeed look wrong.
>
> Thanks
>
> >2/ But I kept dec which is needed for http.
>
> Do you mean org.brotli:dec ? It was there.
>
I must be blind this evening.
Where ?
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Vladimir Sitnikov <si...@gmail.com>.
>1/ I reverted the ones that indeed look wrong.
Thanks
>2/ But I kept dec which is needed for http.
Do you mean org.brotli:dec ? It was there.
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
1/ I reverted the ones that indeed look wrong.
2/ But I kept dec which is needed for http.
On Sat, Nov 9, 2019 at 11:26 PM Philippe Mouawad <ph...@gmail.com>
wrote:
> I still have 2 doubts:
>
> - For com.miglayout:miglayout-swing , isn't it missing ?
> - Is scope runtime in the poms correct ?
>
>
>
>
> On Sat, Nov 9, 2019 at 11:16 PM Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
>> >No, it's one of my concern but that's not what drives my commit.
>> >The Pom are wrong and I am trying to fix it.
>>
>> That is fine. However, this time the fix is wrong, so I suggest to step
>> back and revert it.
>>
>> >Can you explain instead of requesting revert ?
>>
>> Simple explanation: Gradle builds the code, and the resulting binary
>> works.
>> It means all the required jars are declared (either explicitly or they
>> come
>> with transitive dependencies)
>>
>>
>> xpp3 is not used by JMeter code, so the library should not be in the
>> dependencies.
>> In other words, org.xmlpull classes never appear in the source code of
>> JMeter, so the library should not be in the dependencies.
>>
>> As you can see below, xpp3 is used by xtream:jar, and it is declared in
>> the
>> pom file for com.thoughtworks.xstream:xstream:jar:1.4.11
>> (see
>>
>> https://repo1.maven.org/maven2/com/thoughtworks/xstream/xstream/1.4.11.1/xstream-1.4.11.1.pom
>> )
>>
>> $ mvn -f src/core/build/publications/core/pom-default.xml dependency:tree
>> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @
>> ApacheJMeter_core ---
>> [INFO] org.apache.jmeter:ApacheJMeter_core:jar:5.2.1-SNAPSHOT
>> [INFO] +- org.apache.jmeter:ApacheJMeter:jar:5.2.1-SNAPSHOT:compile
>> [INFO] +- org.apache.jmeter:jorphan:jar:5.2.1-SNAPSHOT:compile
>> [INFO] | +- org.slf4j:slf4j-api:jar:1.7.28:compile
>> [INFO] | +- commons-io:commons-io:jar:2.6:runtime
>> [INFO] | \- org.apache.commons:commons-lang3:jar:3.9:runtime
>> [INFO] +- bsf:bsf:jar:2.4.0:compile
>> [INFO] | \- commons-logging:commons-logging:jar:1.0.4:compile
>> [INFO] +- com.fifesoft:rsyntaxtextarea:jar:3.0.4:compile
>> [INFO] +- net.sf.jtidy:jtidy:jar:r938:compile
>>
>> [INFO] +- com.thoughtworks.xstream:xstream:jar:1.4.11:compile
>> [INFO] | +- xmlpull:xmlpull:jar:1.1.3.1:compile
>> [INFO] | \- xpp3:xpp3_min:jar:1.1.4c:compile
>>
>> ^^^ here
>>
>> [INFO] +- org.apache.logging.log4j:log4j-1.2-api:jar:2.12.1:compile
>> [INFO] +- org.apache.logging.log4j:log4j-api:jar:2.12.1:compile
>> [INFO] +- org.apache.logging.log4j:log4j-core:jar:2.12.1:compile
>> [INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.12.1:compile
>> [INFO] +- org.apiguardian:apiguardian-api:jar:1.1.0:compile
>> [INFO] +- oro:oro:jar:2.0.8:compile
>> [INFO] +- xalan:xalan:jar:2.7.2:compile
>> [INFO] | \- xalan:serializer:jar:2.7.2:compile
>> [INFO] +- net.sf.saxon:Saxon-HE:jar:9.9.1-5:compile
>> [INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.28:runtime
>> [INFO] +- commons-codec:commons-codec:jar:1.13:runtime
>> [INFO] +- commons-collections:commons-collections:jar:3.2.2:runtime
>> [INFO] +- com.github.ben-manes.caffeine:caffeine:jar:2.8.0:runtime
>> [INFO] | +- org.checkerframework:checker-qual:jar:2.10.0:runtime
>> [INFO] | \-
>> com.google.errorprone:error_prone_annotations:jar:2.3.3:runtime
>> [INFO] +-
>> com.fasterxml.jackson.core:jackson-annotations:jar:2.9.10:runtime
>> [INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.9.10:runtime
>> [INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.10:runtime
>> [INFO] +- com.miglayout:miglayout-swing:jar:5.2:runtime
>> [INFO] | \- com.miglayout:miglayout-core:jar:5.2:runtime
>> [INFO] +- org.freemarker:freemarker:jar:2.3.29:runtime
>> [INFO] +- org.mozilla:rhino:jar:1.7.11:runtime
>> [INFO] +- org.apache.xmlgraphics:xmlgraphics-commons:jar:2.3:runtime
>> [INFO] +- org.apache.commons:commons-text:jar:1.8:runtime
>> [INFO] +- org.apache.commons:commons-math3:jar:3.6.1:runtime
>> [INFO] +- org.apache.tika:tika-core:jar:1.22:runtime
>> [INFO] +- org.jodd:jodd-core:jar:5.0.13:runtime
>> [INFO] +- org.jodd:jodd-props:jar:5.0.13:runtime
>> [INFO] +- org.codehaus.groovy:groovy-all:jar:2.4.16:runtime
>> [INFO] +- org.apache.tika:tika-parsers:jar:1.22:runtime
>> [INFO] +- xerces:xercesImpl:jar:2.12.0:runtime
>> [INFO] \- xml-apis:xml-apis:jar:1.4.01:runtime
>>
>> >http modules requires HttpClient, it's not referenced , as a
>> > consequence corresponding pom is wrong
>>
>> See
>> $ mvn -f src/protocol/http/build/publications/http/pom-default.xml
>> dependency:tree
>> ...
>> [INFO] +- org.apache.httpcomponents:httpmime:jar:4.5.10:runtime
>> [INFO] | \- org.apache.httpcomponents:httpclient:jar:4.5.10:runtime
>> ...
>>
>>
>> Vladimir
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
I still have 2 doubts:
- For com.miglayout:miglayout-swing , isn't it missing ?
- Is scope runtime in the poms correct ?
On Sat, Nov 9, 2019 at 11:16 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >No, it's one of my concern but that's not what drives my commit.
> >The Pom are wrong and I am trying to fix it.
>
> That is fine. However, this time the fix is wrong, so I suggest to step
> back and revert it.
>
> >Can you explain instead of requesting revert ?
>
> Simple explanation: Gradle builds the code, and the resulting binary works.
> It means all the required jars are declared (either explicitly or they come
> with transitive dependencies)
>
>
> xpp3 is not used by JMeter code, so the library should not be in the
> dependencies.
> In other words, org.xmlpull classes never appear in the source code of
> JMeter, so the library should not be in the dependencies.
>
> As you can see below, xpp3 is used by xtream:jar, and it is declared in the
> pom file for com.thoughtworks.xstream:xstream:jar:1.4.11
> (see
>
> https://repo1.maven.org/maven2/com/thoughtworks/xstream/xstream/1.4.11.1/xstream-1.4.11.1.pom
> )
>
> $ mvn -f src/core/build/publications/core/pom-default.xml dependency:tree
> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @
> ApacheJMeter_core ---
> [INFO] org.apache.jmeter:ApacheJMeter_core:jar:5.2.1-SNAPSHOT
> [INFO] +- org.apache.jmeter:ApacheJMeter:jar:5.2.1-SNAPSHOT:compile
> [INFO] +- org.apache.jmeter:jorphan:jar:5.2.1-SNAPSHOT:compile
> [INFO] | +- org.slf4j:slf4j-api:jar:1.7.28:compile
> [INFO] | +- commons-io:commons-io:jar:2.6:runtime
> [INFO] | \- org.apache.commons:commons-lang3:jar:3.9:runtime
> [INFO] +- bsf:bsf:jar:2.4.0:compile
> [INFO] | \- commons-logging:commons-logging:jar:1.0.4:compile
> [INFO] +- com.fifesoft:rsyntaxtextarea:jar:3.0.4:compile
> [INFO] +- net.sf.jtidy:jtidy:jar:r938:compile
>
> [INFO] +- com.thoughtworks.xstream:xstream:jar:1.4.11:compile
> [INFO] | +- xmlpull:xmlpull:jar:1.1.3.1:compile
> [INFO] | \- xpp3:xpp3_min:jar:1.1.4c:compile
>
> ^^^ here
>
> [INFO] +- org.apache.logging.log4j:log4j-1.2-api:jar:2.12.1:compile
> [INFO] +- org.apache.logging.log4j:log4j-api:jar:2.12.1:compile
> [INFO] +- org.apache.logging.log4j:log4j-core:jar:2.12.1:compile
> [INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.12.1:compile
> [INFO] +- org.apiguardian:apiguardian-api:jar:1.1.0:compile
> [INFO] +- oro:oro:jar:2.0.8:compile
> [INFO] +- xalan:xalan:jar:2.7.2:compile
> [INFO] | \- xalan:serializer:jar:2.7.2:compile
> [INFO] +- net.sf.saxon:Saxon-HE:jar:9.9.1-5:compile
> [INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.28:runtime
> [INFO] +- commons-codec:commons-codec:jar:1.13:runtime
> [INFO] +- commons-collections:commons-collections:jar:3.2.2:runtime
> [INFO] +- com.github.ben-manes.caffeine:caffeine:jar:2.8.0:runtime
> [INFO] | +- org.checkerframework:checker-qual:jar:2.10.0:runtime
> [INFO] | \-
> com.google.errorprone:error_prone_annotations:jar:2.3.3:runtime
> [INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.10:runtime
> [INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.9.10:runtime
> [INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.10:runtime
> [INFO] +- com.miglayout:miglayout-swing:jar:5.2:runtime
> [INFO] | \- com.miglayout:miglayout-core:jar:5.2:runtime
> [INFO] +- org.freemarker:freemarker:jar:2.3.29:runtime
> [INFO] +- org.mozilla:rhino:jar:1.7.11:runtime
> [INFO] +- org.apache.xmlgraphics:xmlgraphics-commons:jar:2.3:runtime
> [INFO] +- org.apache.commons:commons-text:jar:1.8:runtime
> [INFO] +- org.apache.commons:commons-math3:jar:3.6.1:runtime
> [INFO] +- org.apache.tika:tika-core:jar:1.22:runtime
> [INFO] +- org.jodd:jodd-core:jar:5.0.13:runtime
> [INFO] +- org.jodd:jodd-props:jar:5.0.13:runtime
> [INFO] +- org.codehaus.groovy:groovy-all:jar:2.4.16:runtime
> [INFO] +- org.apache.tika:tika-parsers:jar:1.22:runtime
> [INFO] +- xerces:xercesImpl:jar:2.12.0:runtime
> [INFO] \- xml-apis:xml-apis:jar:1.4.01:runtime
>
> >http modules requires HttpClient, it's not referenced , as a
> > consequence corresponding pom is wrong
>
> See
> $ mvn -f src/protocol/http/build/publications/http/pom-default.xml
> dependency:tree
> ...
> [INFO] +- org.apache.httpcomponents:httpmime:jar:4.5.10:runtime
> [INFO] | \- org.apache.httpcomponents:httpclient:jar:4.5.10:runtime
> ...
>
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Vladimir Sitnikov <si...@gmail.com>.
>No, it's one of my concern but that's not what drives my commit.
>The Pom are wrong and I am trying to fix it.
That is fine. However, this time the fix is wrong, so I suggest to step
back and revert it.
>Can you explain instead of requesting revert ?
Simple explanation: Gradle builds the code, and the resulting binary works.
It means all the required jars are declared (either explicitly or they come
with transitive dependencies)
xpp3 is not used by JMeter code, so the library should not be in the
dependencies.
In other words, org.xmlpull classes never appear in the source code of
JMeter, so the library should not be in the dependencies.
As you can see below, xpp3 is used by xtream:jar, and it is declared in the
pom file for com.thoughtworks.xstream:xstream:jar:1.4.11
(see
https://repo1.maven.org/maven2/com/thoughtworks/xstream/xstream/1.4.11.1/xstream-1.4.11.1.pom
)
$ mvn -f src/core/build/publications/core/pom-default.xml dependency:tree
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @
ApacheJMeter_core ---
[INFO] org.apache.jmeter:ApacheJMeter_core:jar:5.2.1-SNAPSHOT
[INFO] +- org.apache.jmeter:ApacheJMeter:jar:5.2.1-SNAPSHOT:compile
[INFO] +- org.apache.jmeter:jorphan:jar:5.2.1-SNAPSHOT:compile
[INFO] | +- org.slf4j:slf4j-api:jar:1.7.28:compile
[INFO] | +- commons-io:commons-io:jar:2.6:runtime
[INFO] | \- org.apache.commons:commons-lang3:jar:3.9:runtime
[INFO] +- bsf:bsf:jar:2.4.0:compile
[INFO] | \- commons-logging:commons-logging:jar:1.0.4:compile
[INFO] +- com.fifesoft:rsyntaxtextarea:jar:3.0.4:compile
[INFO] +- net.sf.jtidy:jtidy:jar:r938:compile
[INFO] +- com.thoughtworks.xstream:xstream:jar:1.4.11:compile
[INFO] | +- xmlpull:xmlpull:jar:1.1.3.1:compile
[INFO] | \- xpp3:xpp3_min:jar:1.1.4c:compile
^^^ here
[INFO] +- org.apache.logging.log4j:log4j-1.2-api:jar:2.12.1:compile
[INFO] +- org.apache.logging.log4j:log4j-api:jar:2.12.1:compile
[INFO] +- org.apache.logging.log4j:log4j-core:jar:2.12.1:compile
[INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.12.1:compile
[INFO] +- org.apiguardian:apiguardian-api:jar:1.1.0:compile
[INFO] +- oro:oro:jar:2.0.8:compile
[INFO] +- xalan:xalan:jar:2.7.2:compile
[INFO] | \- xalan:serializer:jar:2.7.2:compile
[INFO] +- net.sf.saxon:Saxon-HE:jar:9.9.1-5:compile
[INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.28:runtime
[INFO] +- commons-codec:commons-codec:jar:1.13:runtime
[INFO] +- commons-collections:commons-collections:jar:3.2.2:runtime
[INFO] +- com.github.ben-manes.caffeine:caffeine:jar:2.8.0:runtime
[INFO] | +- org.checkerframework:checker-qual:jar:2.10.0:runtime
[INFO] | \- com.google.errorprone:error_prone_annotations:jar:2.3.3:runtime
[INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.10:runtime
[INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.9.10:runtime
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.10:runtime
[INFO] +- com.miglayout:miglayout-swing:jar:5.2:runtime
[INFO] | \- com.miglayout:miglayout-core:jar:5.2:runtime
[INFO] +- org.freemarker:freemarker:jar:2.3.29:runtime
[INFO] +- org.mozilla:rhino:jar:1.7.11:runtime
[INFO] +- org.apache.xmlgraphics:xmlgraphics-commons:jar:2.3:runtime
[INFO] +- org.apache.commons:commons-text:jar:1.8:runtime
[INFO] +- org.apache.commons:commons-math3:jar:3.6.1:runtime
[INFO] +- org.apache.tika:tika-core:jar:1.22:runtime
[INFO] +- org.jodd:jodd-core:jar:5.0.13:runtime
[INFO] +- org.jodd:jodd-props:jar:5.0.13:runtime
[INFO] +- org.codehaus.groovy:groovy-all:jar:2.4.16:runtime
[INFO] +- org.apache.tika:tika-parsers:jar:1.22:runtime
[INFO] +- xerces:xercesImpl:jar:2.12.0:runtime
[INFO] \- xml-apis:xml-apis:jar:1.4.01:runtime
>http modules requires HttpClient, it's not referenced , as a
> consequence corresponding pom is wrong
See
$ mvn -f src/protocol/http/build/publications/http/pom-default.xml
dependency:tree
...
[INFO] +- org.apache.httpcomponents:httpmime:jar:4.5.10:runtime
[INFO] | \- org.apache.httpcomponents:httpclient:jar:4.5.10:runtime
...
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sat, Nov 9, 2019 at 10:55 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >So the commit is not incorrect.
>
> Please revert.
> I'm 100% sure the commit is incorrect.
>
AFAIK:
- AbstractJMeterGuiComponent uses MigLayout
- http modules requires HttpClient, it's not referenced , as a
consequence corresponding pom is wrong
- ...
So what is wrong in this ?
Can you explain instead of requesting revert ? I'd like to understand which
part of the commit is wrong.
I am never sure at 100% of anything, but I think that it's not 100% wrong
> It seems you are driven by "the failure of jmeter-maven-plugin".
>
No, it's one of my concern but that's not what drives my commit.
The Pom are wrong and I am trying to fix it.
However, the failure is caused by j-m-p itself, and adding unused
> dependencies to JMeter is not the right way to workaround j-m-p issue.
>
That's not the topic here.
And If you know an issue on j-m-p, feel free to open an issue, contribute a
PR or 2 cents..., that will help.
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Vladimir Sitnikov <si...@gmail.com>.
>So the commit is not incorrect.
Please revert.
I'm 100% sure the commit is incorrect.
It seems you are driven by "the failure of jmeter-maven-plugin".
However, the failure is caused by j-m-p itself, and adding unused
dependencies to JMeter is not the right way to workaround j-m-p issue.
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
Also, check the 5.2 poms, nowhere httpclient is referenced for example
while it should.
So the commit is not incorrect.
On Sat, Nov 9, 2019 at 10:50 PM Philippe Mouawad <ph...@gmail.com>
wrote:
>
>
> On Sat, Nov 9, 2019 at 10:45 PM Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
>> >implementation("xpp3:xpp3_min")
>> >Used by core for persisting
>>
>> This is very simple to check.
>> xpp3_min-1.1.4c.jar jar contains only org/xmlpull/... classes.
>>
>> $ git grep xmlpull
>> checksum.xml: <dependency group='xmlpull' module='xmlpull'
>> version='1.1.3.1'>
>> gradle.properties:xmlpull.version=1.1.3.1
>> lib/aareadme.txt:xmlpull-1.1.3.1
>> lib/aareadme.txt:http://www.xmlpull.org/impls.shtml
>> src/bom/build.gradle.kts: apiv("xmlpull:xmlpull")
>>
>> That is it. JMeter source code does not use org.xmlpull. classes, so
>> xpp3:xpp3_min dependency should not be added.
>> The same thing is for other dependencies.
>>
>
> I don't think so.
> Mig libraries are needed, it's sure
>
> Regarding xpp3_min, it is needed IMO, we had an issue in the past
> https://bz.apache.org/bugzilla/show_bug.cgi?id=58679
>
>
>> Please revert the changes that add the dependencies.
>>
>> Vladimir
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sat, Nov 9, 2019 at 10:45 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >implementation("xpp3:xpp3_min")
> >Used by core for persisting
>
> This is very simple to check.
> xpp3_min-1.1.4c.jar jar contains only org/xmlpull/... classes.
>
> $ git grep xmlpull
> checksum.xml: <dependency group='xmlpull' module='xmlpull'
> version='1.1.3.1'>
> gradle.properties:xmlpull.version=1.1.3.1
> lib/aareadme.txt:xmlpull-1.1.3.1
> lib/aareadme.txt:http://www.xmlpull.org/impls.shtml
> src/bom/build.gradle.kts: apiv("xmlpull:xmlpull")
>
> That is it. JMeter source code does not use org.xmlpull. classes, so
> xpp3:xpp3_min dependency should not be added.
> The same thing is for other dependencies.
>
I don't think so.
Mig libraries are needed, it's sure
Regarding xpp3_min, it is needed IMO, we had an issue in the past
https://bz.apache.org/bugzilla/show_bug.cgi?id=58679
> Please revert the changes that add the dependencies.
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Vladimir Sitnikov <si...@gmail.com>.
>implementation("xpp3:xpp3_min")
>Used by core for persisting
This is very simple to check.
xpp3_min-1.1.4c.jar jar contains only org/xmlpull/... classes.
$ git grep xmlpull
checksum.xml: <dependency group='xmlpull' module='xmlpull'
version='1.1.3.1'>
gradle.properties:xmlpull.version=1.1.3.1
lib/aareadme.txt:xmlpull-1.1.3.1
lib/aareadme.txt:http://www.xmlpull.org/impls.shtml
src/bom/build.gradle.kts: apiv("xmlpull:xmlpull")
That is it. JMeter source code does not use org.xmlpull. classes, so
xpp3:xpp3_min dependency should not be added.
The same thing is for other dependencies.
Please revert the changes that add the dependencies.
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
Am I misunderstanding the purpose of this ?
See below
On Sat, Nov 9, 2019 at 10:34 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> The ones that you've just added:
> + implementation("com.miglayout:miglayout-core")
>
Used by components in Thread Group UI no ?
> + implementation("com.miglayout:miglayout-swing")
>
Used by components in Thread Group UI no ?
> + implementation("org.ow2.asm:asm")
>
+ implementation("xalan:serializer:xalan")
>
Used by components within XPath elements
> + implementation("xmlpull:xmlpull")
>
Used by core for persisting
> + implementation("xpp3:xpp3_min")
>
Used by core for persisting
and so on.
>
> I'm fine with removal of the versions, however, I'm not fine with adding
> dependencies that are not actually used.
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Vladimir Sitnikov <si...@gmail.com>.
The ones that you've just added:
+ implementation("com.miglayout:miglayout-core")
+ implementation("com.miglayout:miglayout-swing")
+ implementation("org.ow2.asm:asm")
+ implementation("xalan:serializer:xalan")
+ implementation("xmlpull:xmlpull")
+ implementation("xpp3:xpp3_min")
and so on.
I'm fine with removal of the versions, however, I'm not fine with adding
dependencies that are not actually used.
Vladimir
Re: [jmeter] branch master updated: build.gradle.kts in core,
functions, components, protocol: Fix dependencies for pom generation and
remove version
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sat, Nov 9, 2019 at 10:30 PM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >Fix dependencies for pom generation and remove version
>
> Why are the dependencies added?
>
Which ones are not used ?
They are not used by JMeter.
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.