You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/27 18:17:23 UTC
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile opened a new pull request #685: chore: update install engines
jcesarmobile opened a new pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685
master version was bumped to 4.0.0-dev, so the package.json should have a new "5.0.0" entry or will fail to install once released.
Updated the "4.0.0" to require `cordova-ios >=6.0.0-dev` since the ios breaking changes will only work in that new version.
Also updated the engine in `plugin.xml` for also require `cordova-ios >=6.0.0-dev`.
Kept the `cordova >=3.1.0` as nothing was changed to require a newer version, but maybe we should require at least 9?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz merged pull request #685: chore: update install engines
Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on pull request #685: chore: update install engines
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685#issuecomment-628591033
Looks like I was wrong and cordova-ios 6 is not required for IAB to work, master is working fine on 5.1.1.
So changing the requirement to 4.0.0 as some 4.0.0 code checks were removed and won't work on previous versions, but should work on 4+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile edited a comment on pull request #685: chore: update install engines
Posted by GitBox <gi...@apache.org>.
jcesarmobile edited a comment on pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685#issuecomment-628591033
Looks like I was wrong and cordova-ios 6 is not required for IAB to work, master is working fine on 5.1.1.
So changing the requirement to 4.0.0 as some 4.0.0 code checks were removed and older versions won't work, but should work on 4+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on pull request #685: chore: update install engines
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685#issuecomment-620417493
Tests fail with:
```
cordova-plugin-inappbrowser-tests.tests >>
cordova.InAppBrowser
✗ inappbrowser.spec.1 should exist
- Expected undefined to be defined.
```
Maybe the dependencies cannot be loaded because the -dev versions are not on NPM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on pull request #685: chore: update install engines
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685#issuecomment-620431151
Yeah, since this requires cordova-ios 6, test won’t work until it’s released. But better have it here so we don’t forget.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] brodybits commented on a change in pull request #685: chore: update install engines
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685#discussion_r435335489
##########
File path: package.json
##########
@@ -43,6 +43,10 @@
"cordova": ">=3.1.0"
},
"4.0.0": {
+ "cordova": ">=3.1.0",
Review comment:
I think minimum Cordova version should be increased as well, both here and in plugin.xml. I don't think we want to keep supporting old Cordova versions:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on a change in pull request #685: chore: update install engines
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #685:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/685#discussion_r435423478
##########
File path: package.json
##########
@@ -43,6 +43,10 @@
"cordova": ">=3.1.0"
},
"4.0.0": {
+ "cordova": ">=3.1.0",
Review comment:
See https://lists.apache.org/thread.html/rc277f523ceb625820acd4b361e08b3b0269108f19a4d5e85b9d104fd%40%3Cdev.cordova.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org