You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/04/08 23:59:17 UTC
Review Request 45953: Adding a stout interface for `sethostname`
system call in linux.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922
Repository: mesos
Description
-------
Adding a stout interface for `sethostname` system call in linux.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910653ad2f3b663f19395f10214029f1a75e
Diff: https://reviews.apache.org/r/45953/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 45953: Adding a stout interface for `sethostname`
system call in linux.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/
-----------------------------------------------------------
(Updated April 9, 2016, 2:54 p.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Changes
-------
Fixed Jie's comments.
Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922
Repository: mesos
Description
-------
Adding a stout interface for `sethostname` system call in linux.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910653ad2f3b663f19395f10214029f1a75e
Diff: https://reviews.apache.org/r/45953/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 45953: Adding a stout interface for `sethostname`
system call in linux.
Posted by Avinash sridharan <av...@mesosphere.io>.
> On April 9, 2016, 12:45 a.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, lines 277-281
> > <https://reviews.apache.org/r/45953/diff/1/?file=1337639#file1337639line277>
> >
> > HOSTNAME max length might be variable. Will the system below checks the length as well. Why bother adding this additional check?
My bad. Didn't realize sethostname is returning EINVAL if hostname exceeds MAXHOSTNAMELEN.
- Avinash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/#review127935
-----------------------------------------------------------
On April 8, 2016, 9:59 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45953/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 9:59 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding a stout interface for `sethostname` system call in linux.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910653ad2f3b663f19395f10214029f1a75e
>
> Diff: https://reviews.apache.org/r/45953/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 45953: Adding a stout interface for `sethostname`
system call in linux.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45953/#review127935
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 275)
<https://reviews.apache.org/r/45953/#comment191322>
why not const string& ?
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (lines 277 - 281)
<https://reviews.apache.org/r/45953/#comment191324>
HOSTNAME max length might be variable. Will the system below checks the length as well. Why bother adding this additional check?
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 283)
<https://reviews.apache.org/r/45953/#comment191325>
s/</!=/
- Jie Yu
On April 8, 2016, 9:59 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45953/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 9:59 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding a stout interface for `sethostname` system call in linux.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910653ad2f3b663f19395f10214029f1a75e
>
> Diff: https://reviews.apache.org/r/45953/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>