You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/05/02 10:05:39 UTC
[GitHub] flink pull request #5948: [FLINK-9286][docs] Update classloading docs
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5948
[FLINK-9286][docs] Update classloading docs
## What is the purpose of the change
This PR updates the `Configuring ClassLoader Resolution Order` section of the `Debugging Classloading` page.
## Brief change log
* update `classloader.parent-first-pattern` key
* add links to key entries on the configuration page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9286
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5948.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5948
----
commit 78a207710706c185ef57b7a8dc734185a6d64c6b
Author: zentol <ch...@...>
Date: 2018-05-02T10:02:53Z
[FLINK-9286][docs] Update classloading docs
----
---
[GitHub] flink pull request #5948: [FLINK-9286][docs] Update classloading docs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5948
---
[GitHub] flink issue #5948: [FLINK-9286][docs] Update classloading docs
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5948
I agree that the default shouldn't be listed in the common section.
The "Common Options" section will be reworked soon to also be generated (in this [PR](https://github.com/apache/flink/pull/5843)). I suggest to look at which options should be listed there after the PR is merged.
---
[GitHub] flink pull request #5948: [FLINK-9286][docs] Update classloading docs
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5948#discussion_r185731303
--- Diff: docs/monitoring/debugging_classloading.md ---
@@ -69,9 +69,9 @@ cases. By default, Java ClassLoaders will first look for classes in the parent C
the child ClassLoader for cases where we have a hierarchy of ClassLoaders. This is problematic if you
have in your user jar a version of a library that conflicts with a version that comes with Flink. You can
change this behaviour by configuring the ClassLoader resolution order via
-`classloader.resolve-order: child-first` in the Flink config. However, Flink classes will still
+[classloader.resolve-order](../ops/config.html#classloader-resolve-order) in the Flink config. However, Flink classes will still
be resolved through the parent ClassLoader first, although you can also configure this via
-`classloader.parent-first-patterns` (see [config](../ops/config.html))
+[classloader.parent-first-patterns-default](../ops/config.html#classloader-parent-first-patterns-default).
--- End diff --
How about referencing `classloader.parent-first-patterns-additional here instead? The recommendation is not to change the value for "default"...
---
[GitHub] flink issue #5948: [FLINK-9286][docs] Update classloading docs
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5948
Thanks. Will merge this, possibly add one more sentence in the process...
---
[GitHub] flink pull request #5948: [FLINK-9286][docs] Update classloading docs
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5948#discussion_r185733106
--- Diff: docs/monitoring/debugging_classloading.md ---
@@ -69,9 +69,9 @@ cases. By default, Java ClassLoaders will first look for classes in the parent C
the child ClassLoader for cases where we have a hierarchy of ClassLoaders. This is problematic if you
have in your user jar a version of a library that conflicts with a version that comes with Flink. You can
change this behaviour by configuring the ClassLoader resolution order via
-`classloader.resolve-order: child-first` in the Flink config. However, Flink classes will still
+[classloader.resolve-order](../ops/config.html#classloader-resolve-order) in the Flink config. However, Flink classes will still
be resolved through the parent ClassLoader first, although you can also configure this via
-`classloader.parent-first-patterns` (see [config](../ops/config.html))
+[classloader.parent-first-patterns-default](../ops/config.html#classloader-parent-first-patterns-default).
--- End diff --
This particular sentence is about removing Flink from the paren-first pattern, for which you must modify the `default`.
---