[jira] [Commented] (YETUS-464) test-patch silently continues when USER_PLUGIN_DIR doesn't exist

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729779#comment-15729779 ] 

Allen Wittenauer commented on YETUS-464:
----------------------------------------

{code}
+        if [[ ! -d $BASEDIR ]]; then
+          yetus_error "BASEDIR: $BASEDIR does not exist, or is not a directory. Keeping default"
+          BASEDIR=$(pwd)
+        fi
{code}

Should this be fatal?

{code}
+      yetus_error "No system plugins found at ${BINDIR}/test-patch.d"
{code}

This and similar messages should have an ERROR: or WARNING: in the message.  I know we're not always consistent currently, but we should try to be for the future. :)


> test-patch silently continues when USER_PLUGIN_DIR doesn't exist
> ----------------------------------------------------------------
>
>                 Key: YETUS-464
>                 URL: https://issues.apache.org/jira/browse/YETUS-464
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.4.0
>            Reporter: Casey Brotherton
>            Assignee: Casey Brotherton
>            Priority: Minor
>         Attachments: YETUS-464.001.patch, YETUS-464.002.patch, YETUS-464.003.patch
>
>
> If one specifies a directory that does not exist in the --user-plugins argument, test-patch.sh will quietly ignore the directory.
> This was found when using a tilde ( ~ ) to attempt home directory expansion 
> when testing a new plugin.
> Bash does not expand tilde's at the beginning of the line when quoted.
> Thoughts on resolving this:
>   1)  Should warn in the argument section in 01-common.sh if the directory does not exist. ( Not only for USER_PLUGIN_DIR butt for any of the other directories. )
>   2)  It might be possible to change yetus_abs to handle tilde expansion, and then use that code to expand the parameter.  Of note is that yetus_abs is used to expand USER_PLUGIN_DIR in test-patch.sh  
>   3)  If there are changes with the argument handling, it should be considered to check with the arguments to ensure that they are not being overwritten.  ( This would only happen with user error, but makes debugging and understanding more difficult. )
> I will pull together a patch for #1, and reflect on #2/#3 further.  Any comments, please add them to the Jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)