[jira] [Commented] (SLING-5215) getTopology returns wrong topology when not current

["Stefan Egli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980362#comment-14980362 ] 

Stefan Egli commented on SLING-5215:
------------------------------------

discovery.oak fix done in http://svn.apache.org/viewvc?rev=1711239&view=rev
(leaving ticket open as this is also applicable to not-yet-released-but-already-migrated-to-discovery-base-discovery-impl-1.2.0)

> getTopology returns wrong topology when not current
> ---------------------------------------------------
>
>                 Key: SLING-5215
>                 URL: https://issues.apache.org/jira/browse/SLING-5215
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Discovery Oak 1.0.0
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>             Fix For: Discovery Impl 1.2.0, Discovery Oak 1.0.2
>
>
> With the change to discovery.base, the BaseDiscoveryService is now in charge of providing a topology even in the case the view is undefined (not current). In that case it returns the {{oldView}}. That {{oldView}} however is only set at activation time and never updated later. While {{TopologyEventListeners}} are not affected, those who directly call {{getTopology}} will in such a moment get a {{TopologyView}} which is correctly marked as 'not current' - in which case they should anyway not make any assumptions nor use the view - but the view that is returned is actually a very old one - namely from activation including only itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)