You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/22 21:20:29 UTC
[GitHub] [superset] geido opened a new pull request #16394: feat: Draggable and Resizable Modal
geido opened a new pull request #16394:
URL: https://github.com/apache/superset/pull/16394
### SUMMARY
This PR introduces four new options to the Modal component
`resizable`: It makes the Modal resizable using re-resizable
`resizableConfig`: It accepts a re-resizable configuration object
`draggable`: It makes the Modal draggable using react-draggable
`resizableConfig`: It accepts a react-draggable configuration object
The `resizable` and `draggable` are completely independent of each other, they can be used in combination or not used at all.
_Note: When `resizable` or/and `draggable` are used, the Modal mask will be disabled._
_Note: When `resizable` and `draggable` are **not** used, the original Modal node will be returned. This is to minimize the impact of these changes on existing Modals.
### VIEW QUERY MODAL
Both resizable` and `draggable` options have been enabled for the "View Query" Modal. The Modal has been slightly enhanced in order for the `SyntaxHighlighter` Component to take the full height.
### BEFORE
<img width="1680" alt="Screen Shot 2021-08-22 at 23 16 11" src="https://user-images.githubusercontent.com/60598000/130369026-e0bb113b-266d-4b62-91e4-dfaaecca146b.png">
### AFTER
https://user-images.githubusercontent.com/60598000/130369005-45e1e8a5-a90f-4d6c-9814-48918b49ffdd.mp4
### TESTING INSTRUCTIONS
1. Open Explore
2. Click on "View Query"
3. Hover the title and drag the Modal in the window
4. Hover and drag the right, right bottom, and bottom corners to resize the modal
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #16205
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903332998
@rosemarie-chiu @jinghua-qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
geido merged pull request #16394:
URL: https://github.com/apache/superset/pull/16394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #16394:
URL: https://github.com/apache/superset/pull/16394#discussion_r694751528
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -129,6 +150,42 @@ export const StyledModal = styled(BaseModal)<StyledModalProps>`
&.no-content-padding .ant-modal-body {
padding: 0;
}
+
+ ${({ draggable }) =>
+ draggable &&
+ `
+ .ant-modal-header {
+ .draggable-trigger {
+ cursor: move;
+ width: 100%;
+ }
+ }
+ `};
Review comment:
It would be nice if the draggable trigger covered the whole header, not just the title:
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -46,6 +53,10 @@ export interface ModalProps {
wrapProps?: object;
height?: string;
closable?: boolean;
+ resizable?: boolean;
+ resizableConfig?: ResizableProps;
+ draggable?: boolean;
+ draggableConfig?: DraggableProps;
Review comment:
It feels slightly redundant to have four props for essentially two features. Would it be possible to squeeze the `resizable` into `ResizableProps` as an `enabled` prop which is assumed to default to `false`? Same for `draggable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-904454291
Cool @junlincc. Let's get this merged first and I'll have a look at that Modal in the Dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16394:
URL: https://github.com/apache/superset/pull/16394#discussion_r694792055
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -46,6 +53,10 @@ export interface ModalProps {
wrapProps?: object;
height?: string;
closable?: boolean;
+ resizable?: boolean;
+ resizableConfig?: ResizableProps;
+ draggable?: boolean;
+ draggableConfig?: DraggableProps;
Review comment:
I would say that `resizableConfig` and `draggableConfig` might be a bit overkilling here and the only reason why I put them there is that I cannot predict right now how many of those options we will need in the future. We might as well realize we don't need any and just shut them down.
So rather than squeezing `resizable` and `draggable` inside the config which looks like very standard props, I would first implement these types of Modals in a few places and then either shut the config props down altogether or just come up with a few elected ones as overridable defaults. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903451709
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903334817
# [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16394](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (569ff50) into [master](https://codecov.io/gh/apache/superset/commit/c14364c616e709b16774072504657caa857045dc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c14364c) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.07%`.
> :exclamation: Current head 569ff50 differs from pull request most recent head f1f8906. Consider uploading reports for the commit f1f8906 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16394 +/- ##
==========================================
- Coverage 76.33% 76.33% -0.01%
==========================================
Files 1000 1000
Lines 53500 53549 +49
Branches 6819 6848 +29
==========================================
+ Hits 40838 40874 +36
- Misses 12424 12437 +13
Partials 238 238
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.69% <73.07%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `95.65% <ø> (ø)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/explore/components/controls/ViewQueryModal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3UXVlcnlNb2RhbC50c3g=) | `76.92% <66.66%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `85.22% <73.46%> (-14.78%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c14364c...f1f8906](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903334817
# [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16394](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d5fcdf) into [master](https://codecov.io/gh/apache/superset/commit/486ef6b81fb0eab39a3e403bb7fdba784c5e8649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486ef6b) will **increase** coverage by `0.08%`.
> The diff coverage is `73.07%`.
> :exclamation: Current head 3d5fcdf differs from pull request most recent head f1f8906. Consider uploading reports for the commit f1f8906 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16394 +/- ##
==========================================
+ Coverage 76.55% 76.64% +0.08%
==========================================
Files 1000 1000
Lines 53487 53538 +51
Branches 6818 6845 +27
==========================================
+ Hits 40948 41032 +84
+ Misses 12301 12270 -31
+ Partials 238 236 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.89% <73.07%> (+0.19%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `95.65% <ø> (ø)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/explore/components/controls/ViewQueryModal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3UXVlcnlNb2RhbC50c3g=) | `76.92% <66.66%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `85.22% <73.46%> (-14.78%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.42% <0.00%> (-3.16%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <0.00%> (-0.42%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.86% <0.00%> (-0.17%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.25% <0.00%> (-0.06%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpLnB5) | `52.85% <0.00%> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c14364c...f1f8906](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903334817
# [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16394](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d5fcdf) into [master](https://codecov.io/gh/apache/superset/commit/970d7627797fe2b96f797e413b27f09484b80c7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (970d762) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.07%`.
[](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16394 +/- ##
==========================================
- Coverage 76.64% 76.64% -0.01%
==========================================
Files 1000 1000
Lines 53489 53538 +49
Branches 6816 6845 +29
==========================================
+ Hits 40996 41032 +36
- Misses 12257 12270 +13
Partials 236 236
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.89% <73.07%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `95.65% <ø> (ø)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/explore/components/controls/ViewQueryModal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3UXVlcnlNb2RhbC50c3g=) | `76.92% <66.66%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `85.22% <73.46%> (-14.78%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [970d762...3d5fcdf](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903452430
@geido Ephemeral environment spinning up at http://34.219.205.253:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16394:
URL: https://github.com/apache/superset/pull/16394#discussion_r694789209
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -129,6 +150,42 @@ export const StyledModal = styled(BaseModal)<StyledModalProps>`
&.no-content-padding .ant-modal-body {
padding: 0;
}
+
+ ${({ draggable }) =>
+ draggable &&
+ `
+ .ant-modal-header {
+ .draggable-trigger {
+ cursor: move;
+ width: 100%;
+ }
+ }
+ `};
Review comment:
I'll check this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #16394:
URL: https://github.com/apache/superset/pull/16394#discussion_r694889331
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -46,6 +53,10 @@ export interface ModalProps {
wrapProps?: object;
height?: string;
closable?: boolean;
+ resizable?: boolean;
+ resizableConfig?: ResizableProps;
+ draggable?: boolean;
+ draggableConfig?: DraggableProps;
Review comment:
Yes, that works just fine. The reason I pointed this out is this prop structure looked "unexpected" (for the lack of a better word), but I assumed there was a good reason for it. I completely agree; let's get this merged soon and do many small iterative improvements later rather than one big PR now 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903334817
# [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16394](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (569ff50) into [master](https://codecov.io/gh/apache/superset/commit/c14364c616e709b16774072504657caa857045dc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c14364c) will **decrease** coverage by `0.22%`.
> The diff coverage is `73.07%`.
> :exclamation: Current head 569ff50 differs from pull request most recent head 7866549. Consider uploading reports for the commit 7866549 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16394 +/- ##
==========================================
- Coverage 76.55% 76.33% -0.23%
==========================================
Files 1000 1000
Lines 53500 53549 +49
Branches 6819 6848 +29
==========================================
- Hits 40956 40874 -82
- Misses 12306 12437 +131
Partials 238 238
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `70.69% <73.07%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `95.65% <ø> (ø)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/explore/components/controls/ViewQueryModal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3UXVlcnlNb2RhbC50c3g=) | `76.92% <66.66%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `85.22% <73.46%> (-14.78%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `69.80% <0.00%> (-16.87%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.47% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.04% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.00% <0.00%> (-0.39%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c14364c...7866549](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-905489156
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-904212592
solid work!! lgtm! resizable, dragable, scroll as needed, awesome!! can you change the static modal in dashboard to the same? in a 2nd pr is fine
https://user-images.githubusercontent.com/67837651/130533892-2940c3d4-6324-472f-af84-1a591b7d0cc3.mov
https://user-images.githubusercontent.com/67837651/130533995-b94a06d3-c6f5-4189-83de-8f8c22da6718.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16394: feat: Draggable and Resizable Modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16394:
URL: https://github.com/apache/superset/pull/16394#issuecomment-903334817
# [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16394](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7866549) into [master](https://codecov.io/gh/apache/superset/commit/c14364c616e709b16774072504657caa857045dc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c14364c) will **decrease** coverage by `0.02%`.
> The diff coverage is `73.07%`.
[](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16394 +/- ##
==========================================
- Coverage 76.55% 76.52% -0.03%
==========================================
Files 1000 1000
Lines 53500 53537 +37
Branches 6819 6843 +24
==========================================
+ Hits 40956 40969 +13
- Misses 12306 12330 +24
Partials 238 238
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.65% <73.07%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `95.65% <ø> (ø)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/explore/components/controls/ViewQueryModal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaWV3UXVlcnlNb2RhbC50c3g=) | `76.92% <66.66%> (+0.92%)` | :arrow_up: |
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `85.22% <73.46%> (-14.78%)` | :arrow_down: |
| [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `61.48% <0.00%> (-1.41%)` | :arrow_down: |
| [...views/CRUD/alert/components/NotificationMethod.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9Ob3RpZmljYXRpb25NZXRob2QudHN4) | `72.97% <0.00%> (-0.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <0.00%> (-0.42%)` | :arrow_down: |
| [...dashboard/components/SliceHeaderControls/index.tsx](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | `75.00% <0.00%> (-0.40%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.86% <0.00%> (-0.17%)` | :arrow_down: |
| ... and [41 more](https://codecov.io/gh/apache/superset/pull/16394/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c14364c...7866549](https://codecov.io/gh/apache/superset/pull/16394?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org