You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Weihua Jiang (JIRA)" <ji...@apache.org> on 2011/07/05 05:25:22 UTC

[jira] [Created] (HBASE-4059) If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master

If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master
------------------------------------------------------------------------------------------------------

                 Key: HBASE-4059
                 URL: https://issues.apache.org/jira/browse/HBASE-4059
             Project: HBase
          Issue Type: Bug
          Components: master, regionserver
    Affects Versions: 0.90.3, 0.90.2, 0.90.1
            Reporter: Weihua Jiang


When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.

Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
     assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu resolved HBASE-4059.
---------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]

> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060597#comment-13060597 ] 

jiraposter@reviews.apache.org commented on HBASE-4059:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/968/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.

Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
assignmentManager.assign(daughter, true);


This addresses bug HBASE-4059.
    https://issues.apache.org/jira/browse/HBASE-4059


Diffs
-----

  /src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1142708 

Diff: https://reviews.apache.org/r/968/diff


Testing
-------

Ran unit test suite.


Thanks,

Ted



> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4059:
--------------------------

    Summary: If a region is split during RS shutdown process, the daughter regions are NOT made online by master  (was: If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master)

> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4059) If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4059:
--------------------------

    Attachment: 4059.txt

> If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060600#comment-13060600 ] 

jiraposter@reviews.apache.org commented on HBASE-4059:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/968/
-----------------------------------------------------------

(Updated 2011-07-06 14:21:49.237974)


Review request for hbase.


Summary (updated)
-------

When a region is split during the RS shutdown process, RS just writes the daughter region info to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.

Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
assignmentManager.assign(daughter, true);


This addresses bug HBASE-4059.
    https://issues.apache.org/jira/browse/HBASE-4059


Diffs (updated)
-----

  /src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1142708 

Diff: https://reviews.apache.org/r/968/diff


Testing
-------

Ran unit test suite.


Thanks,

Ted



> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060688#comment-13060688 ] 

jiraposter@reviews.apache.org commented on HBASE-4059:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/968/#review971
-----------------------------------------------------------

Ship it!


- Andrew


On 2011-07-06 14:21:49, Ted Yu wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/968/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-06 14:21:49)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  When a region is split during the RS shutdown process, RS just writes the daughter region info to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
bq.  
bq.  Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
bq.  assignmentManager.assign(daughter, true);
bq.  
bq.  
bq.  This addresses bug HBASE-4059.
bq.      https://issues.apache.org/jira/browse/HBASE-4059
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1142708 
bq.  
bq.  Diff: https://reviews.apache.org/r/968/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit test suite.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060809#comment-13060809 ] 

Hudson commented on HBASE-4059:
-------------------------------

Integrated in HBase-TRUNK #2007 (See [https://builds.apache.org/job/HBase-TRUNK/2007/])
    HBASE-4059  If a region is split during RS shutdown process, the daughter
            regions are NOT made online by master

tedyu : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java


> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059913#comment-13059913 ] 

Ted Yu commented on HBASE-4059:
-------------------------------

All unit tests pass for the patch.

> If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060687#comment-13060687 ] 

jiraposter@reviews.apache.org commented on HBASE-4059:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/968/#review970
-----------------------------------------------------------



/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
<https://reviews.apache.org/r/968/#comment2040>

    isDaughterMissing() calls MetaReader.fullScan() which ignores the return value of visitor.visit()
    
    The additional check just excludes the region from being qualified as daughter if the region isn't assigned to any server.


- Ted


On 2011-07-06 14:21:49, Ted Yu wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/968/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-06 14:21:49)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  When a region is split during the RS shutdown process, RS just writes the daughter region info to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
bq.  
bq.  Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
bq.  assignmentManager.assign(daughter, true);
bq.  
bq.  
bq.  This addresses bug HBASE-4059.
bq.      https://issues.apache.org/jira/browse/HBASE-4059
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1142708 
bq.  
bq.  Diff: https://reviews.apache.org/r/968/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit test suite.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060699#comment-13060699 ] 

Ted Yu commented on HBASE-4059:
-------------------------------

Integrate to branch and TRUNK.

Thanks for the review Andrew.

> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4059) If a region is split during RS shutdown process, the daughter regions are NOT made online by master

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060669#comment-13060669 ] 

jiraposter@reviews.apache.org commented on HBASE-4059:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/968/#review968
-----------------------------------------------------------



/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
<https://reviews.apache.org/r/968/#comment2039>

    This doesn't check if the specific table daughter regions are offline, right? Will just stop as soon as it finds an unassigned region?


- Andrew


On 2011-07-06 14:21:49, Ted Yu wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/968/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-06 14:21:49)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  When a region is split during the RS shutdown process, RS just writes the daughter region info to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
bq.  
bq.  Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
bq.  assignmentManager.assign(daughter, true);
bq.  
bq.  
bq.  This addresses bug HBASE-4059.
bq.      https://issues.apache.org/jira/browse/HBASE-4059
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1142708 
bq.  
bq.  Diff: https://reviews.apache.org/r/968/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran unit test suite.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> If a region is split during RS shutdown process, the daughter regions are NOT made online by master
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>         Attachments: 4059.txt
>
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-4059) If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu reassigned HBASE-4059:
-----------------------------

    Assignee: Ted Yu

> If a region is splitted during RS shutdown process, the daughter regions are NOT made online by master
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4059
>                 URL: https://issues.apache.org/jira/browse/HBASE-4059
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3
>            Reporter: Weihua Jiang
>            Assignee: Ted Yu
>
> When a region is splitted during the RS shutdown process, RS just written the daughter region infos to META, but not make them online. Then, for master, in its ServerShutdownHandler, the function isDaughterMissing() uses FindDaughterVisitor to check whether daughter region is OK. However, this visitor doesn't check whether the value for HConstants.SERVER_QUALIFIER carries non-null value.
> Therefore for the scenario, isDaughterMissing() returns false, skipping the following line:
>      assignmentManager.assign(daughter, true);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira