[GitHub] [spark] ulysses-you commented on pull request #32987: [SPARK-35564][SQL] Support subexpression elimination for conditionally evaluated expressions

["ulysses-you (via GitHub)" <gi...@apache.org>]

ulysses-you commented on PR #32987:
URL: https://github.com/apache/spark/pull/32987#issuecomment-1493551994

   The at least once evaluation seems ok that it gives more chance to eliminate subexpression for conditional branches. But as mentioned, the main overhead is, it intoduces more functions during code generation. I wonder Is there some number of performance to confirm we are fine even if a lot of common subexpressions are finally evaluated only once ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org