You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/12/03 14:58:41 UTC
Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs to be
maintained for RU (2.2.x to 2.3.x)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-14169
https://issues.apache.org/jira/browse/AMBARI-14169
Repository: ambari
Description
-------
Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
Diff: https://reviews.apache.org/r/40912/diff/
Testing
-------
Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
-----------------------------------------------------------------------
Ran 271 tests in 8.739s
OK
----------------------------------------------------------------------
Total run:879
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 3, 2015, 6:52 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, lines 131-143
> > <https://reviews.apache.org/r/40912/diff/1/?file=1152941#file1152941line131>
> >
> > We might need similar seting of ranger.usersync.source.impl.class=org.apache.ranger.unixusersync.process.FileSourceUserGroupBuilder when SYNC_SOURCE value is file
We don't need it for RU/EU from 2.2 to 2.3
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108858
-----------------------------------------------------------
On Dec. 3, 2015, 1:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108858
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (lines 131 - 143)
<https://reviews.apache.org/r/40912/#comment168319>
We might need similar seting of ranger.usersync.source.impl.class=org.apache.ranger.unixusersync.process.FileSourceUserGroupBuilder when SYNC_SOURCE value is file
- Jaimin Jetly
On Dec. 3, 2015, 1:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 3, 2015, 7:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, line 127
> > <https://reviews.apache.org/r/40912/diff/1/?file=1152941#file1152941line127>
> >
> > ranger-ugsync-site has this property defaulting to false, but here it is being set to true. Is that correct?
ranger-ugsync-site.xml now have this property ranger.usersync.group.usermapsyncenabled default value as true, so no need to set it during RU/EU. Updating review request, by removing this change.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108862
-----------------------------------------------------------
On Dec. 4, 2015, 4:56 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 4:56 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 3, 2015, 7:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, line 447
> > <https://reviews.apache.org/r/40912/diff/1/?file=1152940#file1152940line447>
> >
> > Same configs need to be called from nonrolling upgrade in HDP 2.2->2.3.
> >
> > see file
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
We have added same configs for nonrolling upgrade (nonrolling-upgrade-2.3.xml, line no 290)
> On Dec. 3, 2015, 7:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, line 82
> > <https://reviews.apache.org/r/40912/diff/1/?file=1152941#file1152941line82>
> >
> > This doesn't make sense. This says,
> > if "xasecure.audit.destination.hdfs" is false, then set it to false
> >
> > Same issue for the property below with a condition that true stays true.
> > the construct of
> >
> > <set key="propname" value="value" /> can be used to forcefully set the value.
The reason why this condition was added is :
on HDP-2.3 default value of xasecure.audit.destination.hdfs is true.
While testing EU from 2.2 to 2.3, it was observed that: even if xasecure.audit.destination.hdfs value is false in HDP-2.2 after upgrading to HDP-2.3 it becomes true.
> On Dec. 3, 2015, 7:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, line 138
> > <https://reviews.apache.org/r/40912/diff/1/?file=1152941#file1152941line138>
> >
> > Does this have to be case insensitive?
> > Need to check if the stack allows LDAP
Values that are used in usersync-properties.xml are in small case only:
<property>
<name>SYNC_SOURCE</name>
<value>unix</value>
<display-name>Sync Source</display-name>
<description>Sync Source</description>
<value-attributes>
<type>value-list</type>
<overridable>false</overridable>
<entries>
<entry>
<value>unix</value>
<label>UNIX</label>
</entry>
<entry>
<value>file</value>
<label>FILE</label>
</entry>
<entry>
<value>ldap</value>
<label>LDAP/AD</label>
</entry>
</entries>
<selection-cardinality>1</selection-cardinality>
</value-attributes>
</property>
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108862
-----------------------------------------------------------
On Dec. 3, 2015, 1:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Dec. 3, 2015, 7:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, line 82
> > <https://reviews.apache.org/r/40912/diff/1/?file=1152941#file1152941line82>
> >
> > This doesn't make sense. This says,
> > if "xasecure.audit.destination.hdfs" is false, then set it to false
> >
> > Same issue for the property below with a condition that true stays true.
> > the construct of
> >
> > <set key="propname" value="value" /> can be used to forcefully set the value.
>
> Gautam Borad wrote:
> The reason why this condition was added is :
>
> on HDP-2.3 default value of xasecure.audit.destination.hdfs is true.
> While testing EU from 2.2 to 2.3, it was observed that: even if xasecure.audit.destination.hdfs value is false in HDP-2.2 after upgrading to HDP-2.3 it becomes true.
Seems like if default changes, EU will modify the value to be from old default to new default. Alejandro when you get a chance can you check?
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108862
-----------------------------------------------------------
On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 3, 2015, 7:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, line 132
> > <https://reviews.apache.org/r/40912/diff/1/?file=1152941#file1152941line132>
> >
> > Does this have to be case insensitive?
> > Default value for the stack is "UNIX"
Default value for stack 2.2 is:
<entry>
<value>unix</value>
<label>UNIX</label>
</entry>
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml#L23-L47
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108862
-----------------------------------------------------------
On Dec. 3, 2015, 1:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108862
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml (line 447)
<https://reviews.apache.org/r/40912/#comment168324>
Same configs need to be called from nonrolling upgrade in HDP 2.2->2.3.
see file
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 82)
<https://reviews.apache.org/r/40912/#comment168325>
This doesn't make sense. This says,
if "xasecure.audit.destination.hdfs" is false, then set it to false
Same issue for the property below with a condition that true stays true.
the construct of
<set key="propname" value="value" /> can be used to forcefully set the value.
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 127)
<https://reviews.apache.org/r/40912/#comment168327>
ranger-ugsync-site has this property defaulting to false, but here it is being set to true. Is that correct?
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 132)
<https://reviews.apache.org/r/40912/#comment168328>
Does this have to be case insensitive?
Default value for the stack is "UNIX"
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 138)
<https://reviews.apache.org/r/40912/#comment168329>
Does this have to be case insensitive?
Need to check if the stack allows LDAP
- Alejandro Fernandez
On Dec. 3, 2015, 1:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review109409
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 79)
<https://reviews.apache.org/r/40912/#comment168903>
This still doesn't make sense: setting the property to false if it's false.
Similar for below with true -> true.
Please test this during EU and RU from HDP 2.2 to 2.3
- Alejandro Fernandez
On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review109058
-----------------------------------------------------------
Ship it!
Marking it ship-it based on the test results and possible behavior clash of how default values are handled in EU.
- Sumit Mohanty
On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review109059
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml
<https://reviews.apache.org/r/40912/#comment168463>
What about users who already have this as "file" What happens to those cluster after stack upgrade?
- Sumit Mohanty
On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review109056
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 9, 2015, 1:10 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, line 79
> > <https://reviews.apache.org/r/40912/diff/2/?file=1153813#file1153813line79>
> >
> > This is clear now. In HDP 2.2, these properties in ranger-env had a different default value.
> > xasecure.audit.destination.hdfs defaulted to false, and the new value in HDP 2.3 is true
> > xasecure.audit.destination.db defaulted to true, and the new value in HDP 2.3 is false
> >
> > In order to preserve the current value of the property during RU from 2.2 to 2.3, the property needs to have the logic of
> > false -> false, or true -> true, otherwise, forcefully setting it overrides the value, and no-op will merge will the new value in HDP 2.3
Thanks Alejandro, am closing this review request.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review109435
-----------------------------------------------------------
On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review109435
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 79)
<https://reviews.apache.org/r/40912/#comment168958>
This is clear now. In HDP 2.2, these properties in ranger-env had a different default value.
xasecure.audit.destination.hdfs defaulted to false, and the new value in HDP 2.3 is true
xasecure.audit.destination.db defaulted to true, and the new value in HDP 2.3 is false
In order to preserve the current value of the property during RU from 2.2 to 2.3, the property needs to have the logic of
false -> false, or true -> true, otherwise, forcefully setting it overrides the value, and no-op will merge will the new value in HDP 2.3
- Alejandro Fernandez
On Dec. 4, 2015, 12:29 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 12:29 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Reverted changes for Alejandro's comment: "ranger-ugsync-site has this property defaulting to false, but here it is being set to true. Is that correct?"
Bugs: AMBARI-14169
https://issues.apache.org/jira/browse/AMBARI-14169
Repository: ambari
Description
-------
Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 88eb9ac
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
Diff: https://reviews.apache.org/r/40912/diff/
Testing
-------
Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
-----------------------------------------------------------------------
Ran 271 tests in 8.739s
OK
----------------------------------------------------------------------
Total run:879
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 4:56 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-14169
https://issues.apache.org/jira/browse/AMBARI-14169
Repository: ambari
Description
-------
Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
Diff: https://reviews.apache.org/r/40912/diff/
Testing
-------
Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
-----------------------------------------------------------------------
Ran 271 tests in 8.739s
OK
----------------------------------------------------------------------
Total run:879
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs
to be maintained for RU (2.2.x to 2.3.x)
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108907
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 132)
<https://reviews.apache.org/r/40912/#comment168369>
Looks like it is case sensitive, so you may either have to change the value to UNIX, or modify the code to be case insensitive (which needs to be discussed with Nate Cole and Jonathan Hurley).
That piece of code is in ConfigureTask.java line 198,
"
if (conditionValue.equals(checkValue)) {
"
- Alejandro Fernandez
On Dec. 3, 2015, 1:58 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 1:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14169
> https://issues.apache.org/jira/browse/AMBARI-14169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after Smart Config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 007f6a4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 98e8e4f
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf
>
> Diff: https://reviews.apache.org/r/40912/diff/
>
>
> Testing
> -------
>
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
>
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>