You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/09/05 12:12:14 UTC

[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #3008: refactor: Refactor oio::Write by accepting oio::Reader instead

suyanhanx commented on code in PR #3008:
URL: https://github.com/apache/incubator-opendal/pull/3008#discussion_r1315806558


##########
core/src/raw/oio/write/api.rs:
##########
@@ -30,8 +30,8 @@ use crate::*;
 pub enum WriteOperation {
     /// Operation for [`Write::write`]
     Write,
-    /// Operation for [`Write::sink`]
-    Sink,

Review Comment:
   Why change name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org