You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Aakash Nand <aa...@gmail.com> on 2021/10/11 04:48:27 UTC

Review Request 73643: RANGER-3182 Rename Prestosql to trino and fix classpath errors

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73643/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-3182
    https://issues.apache.org/jira/browse/RANGER-3182


Repository: ranger


Description
-------

Hi,
I have created a patch which migrates existing prestosql references to rebranded trino. I have also fixed some classpath errors in ranger-trino-plugin. This ensures the plugin works with new Trino version 361.


Diffs
-----

  agents-common/scripts/enable-agent.sh ad021feee 
  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 7775b0871 
  agents-common/src/main/resources/log4j.properties PRE-CREATION 
  agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json b16b02a7b 
  distro/pom.xml 0c65df251 
  distro/src/main/assembly/admin-web.xml 3fc054d7c 
  distro/src/main/assembly/plugin-presto.xml 3043777d6 
  plugin-presto/.gitignore  
  plugin-presto/conf/ranger-policymgr-ssl-changes.cfg  
  plugin-presto/conf/ranger-policymgr-ssl.xml 5ac7cf14c 
  plugin-presto/conf/ranger-presto-audit-changes.cfg  
  plugin-presto/conf/ranger-presto-audit.xml d335974f2 
  plugin-presto/conf/ranger-presto-security-changes.cfg 5a89cfa2d 
  plugin-presto/conf/ranger-presto-security.xml 9feae81a6 
  plugin-presto/pom.xml 3246eda1c 
  plugin-presto/scripts/install.properties 956533571 
  plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f9f3e4fb5 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java 164b8f930 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java 352979381 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoConnectionManager.java 4a642ea51 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java c9f38266e 
  plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java bcfaef05e 
  plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java ed8c837d5 
  plugin-presto/src/test/resources/log4j.properties  
  plugin-presto/src/test/resources/presto-policies.json 6dbaabb1c 
  plugin-presto/src/test/resources/ranger-presto-security.xml 8a1923d4d 
  plugin-trino/conf/ranger-trino-security-changes.cfg PRE-CREATION 
  pom.xml 626591d60 
  ranger-presto-plugin-shim/.gitignore  
  ranger-presto-plugin-shim/pom.xml 4117b0388 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/PrestoRangerPlugin.java fe707726d 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java e0ab0f3ee 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 40638701f 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlFactory.java e446ada03 
  ranger-presto-plugin-shim/src/main/resources/META-INF/services/io.prestosql.spi.Plugin ff40776aa 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPrestoToSupportPresto333_J10038.java f64773303 


Diff: https://reviews.apache.org/r/73643/diff/1/


Testing
-------


Thanks,

Aakash Nand


Re: Review Request 73643: RANGER-3182 Rename Prestosql to trino and fix classpath errors

Posted by Aakash Nand <aa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73643/
-----------------------------------------------------------

(Updated Oct. 11, 2021, 5:03 a.m.)


Review request for ranger.


Bugs: RANGER-3182
    https://issues.apache.org/jira/browse/RANGER-3182


Repository: ranger


Description
-------

Hi,
I have created a patch which migrates existing prestosql references to rebranded trino. I have also fixed some classpath errors in ranger-trino-plugin. This ensures the plugin works with new Trino version 361.


Diffs
-----

  agents-common/scripts/enable-agent.sh ad021feee 
  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 7775b0871 
  agents-common/src/main/resources/log4j.properties PRE-CREATION 
  agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json b16b02a7b 
  distro/pom.xml 0c65df251 
  distro/src/main/assembly/admin-web.xml 3fc054d7c 
  distro/src/main/assembly/plugin-presto.xml 3043777d6 
  plugin-presto/.gitignore  
  plugin-presto/conf/ranger-policymgr-ssl-changes.cfg  
  plugin-presto/conf/ranger-policymgr-ssl.xml 5ac7cf14c 
  plugin-presto/conf/ranger-presto-audit-changes.cfg  
  plugin-presto/conf/ranger-presto-audit.xml d335974f2 
  plugin-presto/conf/ranger-presto-security-changes.cfg 5a89cfa2d 
  plugin-presto/conf/ranger-presto-security.xml 9feae81a6 
  plugin-presto/pom.xml 3246eda1c 
  plugin-presto/scripts/install.properties 956533571 
  plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f9f3e4fb5 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java 164b8f930 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java 352979381 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoConnectionManager.java 4a642ea51 
  plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java c9f38266e 
  plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java bcfaef05e 
  plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java ed8c837d5 
  plugin-presto/src/test/resources/log4j.properties  
  plugin-presto/src/test/resources/presto-policies.json 6dbaabb1c 
  plugin-presto/src/test/resources/ranger-presto-security.xml 8a1923d4d 
  plugin-trino/conf/ranger-trino-security-changes.cfg PRE-CREATION 
  pom.xml 626591d60 
  ranger-presto-plugin-shim/.gitignore  
  ranger-presto-plugin-shim/pom.xml 4117b0388 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/PrestoRangerPlugin.java fe707726d 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java e0ab0f3ee 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 40638701f 
  ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlFactory.java e446ada03 
  ranger-presto-plugin-shim/src/main/resources/META-INF/services/io.prestosql.spi.Plugin ff40776aa 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForPrestoToSupportPresto333_J10038.java f64773303 


Diff: https://reviews.apache.org/r/73643/diff/1/


Testing (updated)
-------

For testing 
Along with this patch I built the ranger from source using master branch and tested by creating trino policies. It is working as expected.


Thanks,

Aakash Nand