[GitHub] [arrow] adamreeve commented on a diff in pull request #35996: GH-35988: [C#] The C data interface implementation can leak on import

["adamreeve (via GitHub)" <gi...@apache.org>]

adamreeve commented on code in PR #35996:
URL: https://github.com/apache/arrow/pull/35996#discussion_r1223797124


##########
csharp/src/Apache.Arrow/C/CArrowSchemaExporter.cs:
##########
@@ -50,10 +50,6 @@ public static unsafe void ExportType(IArrowType datatype, CArrowSchema* schema)
             {
                 throw new ArgumentNullException(nameof(schema));
             }
-            if (schema->release != null)
-            {
-                throw new ArgumentException("Cannot export schema to a struct that is already initialized.");

Review Comment:
   For what it's worth, it looks like this change fixes an issue I ran into using a C# exported stream from an older version of C++ Arrow, where the schema struct used when importing the stream was uninitialized: https://github.com/apache/arrow/blob/apache-arrow-10.0.1/cpp/src/arrow/c/bridge.cc#L1782 (this has since been fixed)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org