[GitHub] [airflow] vandonr-amz commented on a diff in pull request #32036: Add a deferrable mode to `BatchCreateComputeEnvironmentOperator`

["vandonr-amz (via GitHub)" <gi...@apache.org>]

vandonr-amz commented on code in PR #32036:
URL: https://github.com/apache/airflow/pull/32036#discussion_r1235942304


##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -428,31 +431,40 @@ def __init__(
         unmanaged_v_cpus: int | None = None,
         service_role: str | None = None,
         tags: dict | None = None,
-        max_retries: int | None = None,
+        poll_interval: int = 30,
+        max_retries: int = 120,

Review Comment:
   I think we have handled this as non-breaking so far in other PRs 🤔 
   my understanding is that None is here only for the default, and like, who would pass an explicit `None` in their right mind ?
   But yeah, I guess every change is a breaking change, I can add a warning around this if you think it's necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org