You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Giannis Koutsoubos (JIRA)" <ji...@apache.org> on 2011/01/14 17:55:45 UTC
[jira] Created: (WICKET-3335) Component Queuing (extract hierarchy
information from markup)
Component Queuing (extract hierarchy information from markup)
-------------------------------------------------------------
Key: WICKET-3335
URL: https://issues.apache.org/jira/browse/WICKET-3335
Project: Wicket
Issue Type: New Feature
Components: wicket
Reporter: Giannis Koutsoubos
Doubly defined hierarhices are redundant.
Server-side hierarchy can be automatically deduced from markup hierarchy.
Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Martin Makundi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983098#action_12983098 ]
Martin Makundi commented on WICKET-3335:
----------------------------------------
I vote
+1 for adding it to 1.4.x
because this feature does not compromise anything, it is just an alternate way of adding components.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (WICKET-3335) Component Queuing (extract hierarchy
information from markup)
Posted by "Igor Vaynberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-3335:
----------------------------------
Fix Version/s: (was: 6.0.0-RC1)
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Ondra Žižka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032534#comment-13032534 ]
Ondra Žižka commented on WICKET-3335:
-------------------------------------
..which leads me to another idea - jQuery-like components selectors:
getComponents("Form#form1 WebMarkupContainer.holder input"); // CSS-like syntax
That would traverse this component's tree and return a collection of matching components.
Components could have CSS-like classes for this purpose.
Or with a collection proxy able to change the component...
getComponents("Form#form1 WebMarkupContainer.holder input").setVisible(false)
Was something like that proposed?
Maybe this could bring some fresh air to solutions for things like group of checkboxes etc.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3335) Component Queuing (extract hierarchy
information from markup)
Posted by "Giannis Koutsoubos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giannis Koutsoubos updated WICKET-3335:
---------------------------------------
Attachment: 0001-component-queuing.patch
patch that provides component queuing support on wicket-1.4.x branch
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (WICKET-3335) Component Queuing (extract hierarchy
information from markup)
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3335:
------------------------------------
Fix Version/s: (was: 6.0.0-beta1)
6.0.0-RC1
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Fix For: 6.0.0-RC1
>
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053299#comment-13053299 ]
Igor Vaynberg commented on WICKET-3335:
---------------------------------------
its not exactly how it works. queue(new Container("c1")) will not be immediately executed, none of them will. unqueueing happens after/before? the initialization of the component when the markup is available.
when dequeuing we try to find a queued child closest to the container, so in the example above it will work like this:
resolving c1, found and dequeued
resolving c1->input. look in c1, not found. look in parent, found and dequeued
resolving c2. look in c1, not found. look in parent, found and dequeued
resolving c2->input: look in c2, found and dequeued
also i now think queue is too cumberson to type, we should probably rename it to "push"
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062681#comment-13062681 ]
Juergen Donnerstag commented on WICKET-3335:
--------------------------------------------
@Igor not sure I understand. I thought that for all components (queued or not) onInitialize gets called in any case after it was added and it's markup is available. onInitialize will never be called for queued components while still waiting to be added. During unqueuing the component gets added and because it's markup is guaranteed to be available, onInitialize gets called. Did I misunderstand your question?
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Fix For: 1.6.0
>
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236681#comment-13236681 ]
Igor Vaynberg commented on WICKET-3335:
---------------------------------------
this is a much more complex problem that i thought initially, mainly because it has to work with auto resolved tags which "pollute" nesting information in markup.
some unfinished attempts at this are in the origin/sandbox/component-queueing and origin/sandbox/hierarchy-completion branches.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030386#comment-13030386 ]
Juergen Donnerstag commented on WICKET-3335:
--------------------------------------------
Another way to solve it (we actually had that in 1.2 or so) is to extend/replace the component resolution process.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062680#comment-13062680 ]
Juergen Donnerstag commented on WICKET-3335:
--------------------------------------------
It's now available on github as well https://github.com/jdonnerstag/wicket/tree/queuing
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Fix For: 1.6.0
>
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062683#comment-13062683 ]
Igor Vaynberg commented on WICKET-3335:
---------------------------------------
@Juergen
i simply stated that there should be tests that check the hierarchy in a queued component's oninitialize method. eg, to make sure oninitialize is not called on queue, but rather after dequeue.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Fix For: 1.6.0
>
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-3335) Component Queuing
(extract hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030390#comment-13030390 ]
Igor Vaynberg edited comment on WICKET-3335 at 5/7/11 7:01 PM:
---------------------------------------------------------------
@Juergen: i dont like doing that. the hierarchical information defined in java/markup is very important and i would not want to do lose that...
was (Author: ivaynberg):
i dont like doing that. the hierarchical information defined in java/markup is very important and i would not want to do lose that...
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032540#comment-13032540 ]
Igor Vaynberg commented on WICKET-3335:
---------------------------------------
yes, something like this was proposed, but does not seem very useful. how often do you use a visitor to do something in wicket? which is what this is, a shorthand for visitors.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Ondra Žižka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032521#comment-13032521 ]
Ondra Žižka commented on WICKET-3335:
-------------------------------------
A note to http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-tp3027705p3028177.html :
Perhaps hierarchy ambiguities could be solved by introducing a concept of "component tree path", e.g. instead of
add("form1").add("input");
add("form2").add("input")
we could have (while keeping backwards compatibility):
add("form1")
add("form1.input")
add("form2")
add("form2.input")
(Which might be what Juergen meant by "extending component resolution process".)
Pro: More flat code
Con: Less semantical code, performance drawback(?)
I'm not really sure what would I prefer. But it would fit with PropertyModel.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Giannis Koutsoubos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984226#action_12984226 ]
Giannis Koutsoubos commented on WICKET-3335:
--------------------------------------------
support for 1.5 https://github.com/koutsoub/wicket/tree/component_queuing_1.5
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053284#comment-13053284 ]
Juergen Donnerstag commented on WICKET-3335:
--------------------------------------------
What shall be the resolution logic in the example below
c1->input
c1->c2->input
Container c2;
queue(new Container("c1"));
queue(c2=new Container("c2"));
queue(new Input("input"));
c2.queue(new Input("input"));
I assume:
queue(new Container("c1")); will immediately be executed because we don't need to wait for anything
queue(c2=new Container("c2")); same; invoke add() immediately
queue(new Input("input")); can be added to c1 or c2. Shall that request be stalled until later? Until when? Or shall it be added to the first occassion it finds (without a warning)?
c2.queue(new Input("input")); can be executed immediately without ambiguity. Should we retry the postponed entry now? In that case queue can only do add but no replace (IMO not a heavy limitation).
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030390#comment-13030390 ]
Igor Vaynberg commented on WICKET-3335:
---------------------------------------
i dont like doing that. the hierarchical information defined in java/markup is very important and i would not want to do lose that...
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3335) Component Queuing (extract hierarchy
information from markup)
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag updated WICKET-3335:
---------------------------------------
Attachment: wicket-3335.patch
Find attached my little attempt to implement queuing. Feel free add more test cases, review or comment
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3335) Component Queuing (extract hierarchy
information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-3335:
----------------------------------
Fix Version/s: 1.6.0
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Fix For: 1.6.0
>
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032528#comment-13032528 ]
Igor Vaynberg commented on WICKET-3335:
---------------------------------------
there shouldnt be any ambiguities because all containers support queuing.
so if you have two components with the same id and you want to queue them both you have to queue them under a parent that will not cause ambiguities, eg
lets say you have
c1->input
c1->c2->input
the following code should obviously not work
queue(new Container("c1"));
queue(new Container("c2"));
queue(new Input("input"));
queue(new Input("input"));
because the page does not know how to resolve which input goes where, but - the following
Container c2;
queue(new Container("c1"));
queue(c2=new Container("c2"));
queue(new Input("input"));
c2.queue(new Input("input"));
should work because we have removed the ambiguity.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Attachments: 0001-component-queuing.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062617#comment-13062617 ]
Igor Vaynberg commented on WICKET-3335:
---------------------------------------
@Juergen, right now your tests only test for rendering, but they should also test that before queued component's oninitialize is called the component is already a child of the correct parent.
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Fix For: 1.6.0
>
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-3335) Component Queuing (extract
hierarchy information from markup)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-3335:
-------------------------------------
Assignee: Igor Vaynberg
> Component Queuing (extract hierarchy information from markup)
> -------------------------------------------------------------
>
> Key: WICKET-3335
> URL: https://issues.apache.org/jira/browse/WICKET-3335
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-core
> Reporter: Giannis Koutsoubos
> Assignee: Igor Vaynberg
> Fix For: 1.6.0
>
> Attachments: 0001-component-queuing.patch, wicket-3335.patch
>
>
> Doubly defined hierarhices are redundant.
> Server-side hierarchy can be automatically deduced from markup hierarchy.
> Use queue method in MarkupContainer to add components and extract hierarchy information from markup.
> Discussed here: http://apache-wicket.1842946.n4.nabble.com/Free-wicket-from-component-hierarchy-hell-td3027705.html
> Implementation of queue method on branch 1.4.x : https://github.com/koutsoub/wicket/tree/component-queuing
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira