You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/11/22 17:52:48 UTC
Review Request 15788: [QMF] Issue compiler error on use of deprecated API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
Bugs: qpid-5369
https://issues.apache.org/jira/browse/qpid-5369
Repository: qpid
Description
-------
Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
The compiler error reads:
In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
Diffs
-----
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/list_agents.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/print_events.cpp 1543123
/trunk/qpid/cpp/include/qmf/Agent.h 1543123
/trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123
/trunk/qpid/cpp/include/qmf/AgentSession.h 1543123
/trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123
/trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123
/trunk/qpid/cpp/include/qmf/Data.h 1543123
/trunk/qpid/cpp/include/qmf/DataAddr.h 1543123
/trunk/qpid/cpp/include/qmf/Handle.h 1543123
/trunk/qpid/cpp/include/qmf/Query.h 1543123
/trunk/qpid/cpp/include/qmf/Schema.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaId.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaTypes.h 1543123
/trunk/qpid/cpp/include/qmf/Subscription.h 1543123
/trunk/qpid/cpp/include/qmf/exceptions.h 1543123
/trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123
/trunk/qpid/cpp/include/qmf/qmf2.i 1543123
Diff: https://reviews.apache.org/r/15788/diff/
Testing
-------
Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
Thanks,
Kenneth Giusti
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Chug Rolke <cr...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/#review29304
-----------------------------------------------------------
/trunk/qpid/cpp/include/qmf/Agent.h
<https://reviews.apache.org/r/15788/#comment56464>
Could you restate this in terms of enabling the API instead of getting rid of the error message?
"Define 'QMF_USE_DEPRECATED_API' to enable continued use of the qmf API"
(repeat multiple places)
- Chug Rolke
On Nov. 22, 2013, 4:55 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15788/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 4:55 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
>
>
> Bugs: qpid-5369
> https://issues.apache.org/jira/browse/qpid-5369
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
>
> The compiler error reads:
>
> In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
>
> Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/list_agents.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/print_events.cpp 1543123
> /trunk/qpid/cpp/include/qmf/Agent.h 1543123
> /trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123
> /trunk/qpid/cpp/include/qmf/AgentSession.h 1543123
> /trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123
> /trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123
> /trunk/qpid/cpp/include/qmf/Data.h 1543123
> /trunk/qpid/cpp/include/qmf/DataAddr.h 1543123
> /trunk/qpid/cpp/include/qmf/Handle.h 1543123
> /trunk/qpid/cpp/include/qmf/Query.h 1543123
> /trunk/qpid/cpp/include/qmf/Schema.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaId.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaTypes.h 1543123
> /trunk/qpid/cpp/include/qmf/Subscription.h 1543123
> /trunk/qpid/cpp/include/qmf/exceptions.h 1543123
> /trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123
> /trunk/qpid/cpp/include/qmf/qmf2.i 1543123
>
> Diff: https://reviews.apache.org/r/15788/diff/
>
>
> Testing
> -------
>
> Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Justin Ross <jr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/#review29446
-----------------------------------------------------------
Ship it!
The python looks good to me.
- Justin Ross
On Nov. 26, 2013, 4:52 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15788/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2013, 4:52 p.m.)
>
>
> Review request for qpid and Justin Ross.
>
>
> Bugs: qpid-5369
> https://issues.apache.org/jira/browse/qpid-5369
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
>
> The compiler error reads:
>
> In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
>
> Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/bindings/qmf2/python/qmf2.py 1545563
> /trunk/qpid/cpp/bindings/qmf2/ruby/qmf2.rb 1545563
>
> Diff: https://reviews.apache.org/r/15788/diff/
>
>
> Testing
> -------
>
> Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Kenneth Giusti <kg...@apache.org>.
> On Nov. 26, 2013, 5:51 p.m., Andrew Stitcher wrote:
> > This looks good to me (but I'm not a python or ruby expert).
> >
> > Did you intend to make the warning unconditional though? It seems there is no way to turn it off if you "know what you are doing". That might be a little alarming to end users of a program that uses it.
(Neither am I :) I merely did a "copy and pasta" from examples of deprecated modules that I have in my machine's local Ruby and Python installations. My assumption - ugh - is that this would be compliant with the existing practice.
- Kenneth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/#review29442
-----------------------------------------------------------
On Nov. 26, 2013, 4:52 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15788/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2013, 4:52 p.m.)
>
>
> Review request for qpid and Justin Ross.
>
>
> Bugs: qpid-5369
> https://issues.apache.org/jira/browse/qpid-5369
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
>
> The compiler error reads:
>
> In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
>
> Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/bindings/qmf2/python/qmf2.py 1545563
> /trunk/qpid/cpp/bindings/qmf2/ruby/qmf2.rb 1545563
>
> Diff: https://reviews.apache.org/r/15788/diff/
>
>
> Testing
> -------
>
> Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/#review29442
-----------------------------------------------------------
This looks good to me (but I'm not a python or ruby expert).
Did you intend to make the warning unconditional though? It seems there is no way to turn it off if you "know what you are doing". That might be a little alarming to end users of a program that uses it.
- Andrew Stitcher
On Nov. 26, 2013, 4:52 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15788/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2013, 4:52 p.m.)
>
>
> Review request for qpid and Justin Ross.
>
>
> Bugs: qpid-5369
> https://issues.apache.org/jira/browse/qpid-5369
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
>
> The compiler error reads:
>
> In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
>
> Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/bindings/qmf2/python/qmf2.py 1545563
> /trunk/qpid/cpp/bindings/qmf2/ruby/qmf2.rb 1545563
>
> Diff: https://reviews.apache.org/r/15788/diff/
>
>
> Testing
> -------
>
> Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/
-----------------------------------------------------------
(Updated Nov. 26, 2013, 4:52 p.m.)
Review request for qpid and Justin Ross.
Changes
-------
Addendum: for the sake of completeness - add warnings to the wrapped modules too.
Bugs: qpid-5369
https://issues.apache.org/jira/browse/qpid-5369
Repository: qpid
Description
-------
Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
The compiler error reads:
In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
Diffs (updated)
-----
/trunk/qpid/cpp/bindings/qmf2/python/qmf2.py 1545563
/trunk/qpid/cpp/bindings/qmf2/ruby/qmf2.rb 1545563
Diff: https://reviews.apache.org/r/15788/diff/
Testing
-------
Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
Thanks,
Kenneth Giusti
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/#review29373
-----------------------------------------------------------
/trunk/qpid/cpp/include/qmf/Agent.h
<https://reviews.apache.org/r/15788/#comment56570>
For the sake of DRY could you put these lines in qmf/ImportExport.h?
It's not a blocking issue, my eye is just offended by so much repetition.
/trunk/qpid/cpp/include/qmf/SchemaTypes.h
<https://reviews.apache.org/r/15788/#comment56571>
Looks like this is the only block that doesn't precede an include of qmf/ImportExport.h, so perhaps move the error in there and replace this with #include "qmf/ImportExport.h"
- Andrew Stitcher
On Nov. 22, 2013, 9:01 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15788/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 9:01 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
>
>
> Bugs: qpid-5369
> https://issues.apache.org/jira/browse/qpid-5369
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
>
> The compiler error reads:
>
> In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
>
> Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/list_agents.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/print_events.cpp 1543123
> /trunk/qpid/cpp/include/qmf/Agent.h 1543123
> /trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123
> /trunk/qpid/cpp/include/qmf/AgentSession.h 1543123
> /trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123
> /trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123
> /trunk/qpid/cpp/include/qmf/Data.h 1543123
> /trunk/qpid/cpp/include/qmf/DataAddr.h 1543123
> /trunk/qpid/cpp/include/qmf/Handle.h 1543123
> /trunk/qpid/cpp/include/qmf/Query.h 1543123
> /trunk/qpid/cpp/include/qmf/Schema.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaId.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaTypes.h 1543123
> /trunk/qpid/cpp/include/qmf/Subscription.h 1543123
> /trunk/qpid/cpp/include/qmf/exceptions.h 1543123
> /trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123
> /trunk/qpid/cpp/include/qmf/qmf2.i 1543123
>
> Diff: https://reviews.apache.org/r/15788/diff/
>
>
> Testing
> -------
>
> Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Chug Rolke <cr...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/#review29372
-----------------------------------------------------------
Ship it!
Ship It!
- Chug Rolke
On Nov. 22, 2013, 9:01 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15788/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 9:01 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
>
>
> Bugs: qpid-5369
> https://issues.apache.org/jira/browse/qpid-5369
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
>
> The compiler error reads:
>
> In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
> /home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
>
> Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/list_agents.cpp 1543123
> /trunk/qpid/cpp/bindings/qmf2/examples/cpp/print_events.cpp 1543123
> /trunk/qpid/cpp/include/qmf/Agent.h 1543123
> /trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123
> /trunk/qpid/cpp/include/qmf/AgentSession.h 1543123
> /trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123
> /trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123
> /trunk/qpid/cpp/include/qmf/Data.h 1543123
> /trunk/qpid/cpp/include/qmf/DataAddr.h 1543123
> /trunk/qpid/cpp/include/qmf/Handle.h 1543123
> /trunk/qpid/cpp/include/qmf/Query.h 1543123
> /trunk/qpid/cpp/include/qmf/Schema.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaId.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123
> /trunk/qpid/cpp/include/qmf/SchemaTypes.h 1543123
> /trunk/qpid/cpp/include/qmf/Subscription.h 1543123
> /trunk/qpid/cpp/include/qmf/exceptions.h 1543123
> /trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123
> /trunk/qpid/cpp/include/qmf/qmf2.i 1543123
>
> Diff: https://reviews.apache.org/r/15788/diff/
>
>
> Testing
> -------
>
> Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/
-----------------------------------------------------------
(Updated Nov. 22, 2013, 9:01 p.m.)
Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
Changes
-------
Update per Chug's input.
Bugs: qpid-5369
https://issues.apache.org/jira/browse/qpid-5369
Repository: qpid
Description
-------
Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
The compiler error reads:
In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
Diffs (updated)
-----
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/list_agents.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/print_events.cpp 1543123
/trunk/qpid/cpp/include/qmf/Agent.h 1543123
/trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123
/trunk/qpid/cpp/include/qmf/AgentSession.h 1543123
/trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123
/trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123
/trunk/qpid/cpp/include/qmf/Data.h 1543123
/trunk/qpid/cpp/include/qmf/DataAddr.h 1543123
/trunk/qpid/cpp/include/qmf/Handle.h 1543123
/trunk/qpid/cpp/include/qmf/Query.h 1543123
/trunk/qpid/cpp/include/qmf/Schema.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaId.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaTypes.h 1543123
/trunk/qpid/cpp/include/qmf/Subscription.h 1543123
/trunk/qpid/cpp/include/qmf/exceptions.h 1543123
/trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123
/trunk/qpid/cpp/include/qmf/qmf2.i 1543123
Diff: https://reviews.apache.org/r/15788/diff/
Testing
-------
Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
Thanks,
Kenneth Giusti
Re: Review Request 15788: [QMF] Issue compiler error on use of deprecated API
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15788/
-----------------------------------------------------------
(Updated Nov. 22, 2013, 4:55 p.m.)
Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
Bugs: qpid-5369
https://issues.apache.org/jira/browse/qpid-5369
Repository: qpid
Description (updated)
-------
Causes any application that includes the QMF Agent or Console C++ headers to issue a compile-time error unless QMF_USE_DEPRECATED_API is defined by the application.
The compiler error reads:
In file included from /home/kgiusti/work/qpid/qpid/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp:22:0:
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:25:4: error: #error "The API defined in this file has been DEPRECATED and will be removed in the future."
/home/kgiusti/work/qpid/qpid/qpid/cpp/include/qmf/AgentSession.h:26:4: error: #error "Define 'QMF_USE_DEPRECATED_API' to disable this error."
Note: I'd like to propose this gets in for 0.26 - if you agree please comment as such on the JIRA, thanks.
Diffs
-----
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/agent.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/list_agents.cpp 1543123
/trunk/qpid/cpp/bindings/qmf2/examples/cpp/print_events.cpp 1543123
/trunk/qpid/cpp/include/qmf/Agent.h 1543123
/trunk/qpid/cpp/include/qmf/AgentEvent.h 1543123
/trunk/qpid/cpp/include/qmf/AgentSession.h 1543123
/trunk/qpid/cpp/include/qmf/ConsoleEvent.h 1543123
/trunk/qpid/cpp/include/qmf/ConsoleSession.h 1543123
/trunk/qpid/cpp/include/qmf/Data.h 1543123
/trunk/qpid/cpp/include/qmf/DataAddr.h 1543123
/trunk/qpid/cpp/include/qmf/Handle.h 1543123
/trunk/qpid/cpp/include/qmf/Query.h 1543123
/trunk/qpid/cpp/include/qmf/Schema.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaId.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaMethod.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaProperty.h 1543123
/trunk/qpid/cpp/include/qmf/SchemaTypes.h 1543123
/trunk/qpid/cpp/include/qmf/Subscription.h 1543123
/trunk/qpid/cpp/include/qmf/exceptions.h 1543123
/trunk/qpid/cpp/include/qmf/posix/EventNotifier.h 1543123
/trunk/qpid/cpp/include/qmf/qmf2.i 1543123
Diff: https://reviews.apache.org/r/15788/diff/
Testing
-------
Tested on windows (VS 2010) and linux (Fedora 18), both with and without QMF_USE_DEPRECATED_API defined.
Thanks,
Kenneth Giusti