You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/05/08 19:50:00 UTC
[jira] [Commented] (ARTEMIS-2323) NettyTransport should also send
requests with void promises
[ https://issues.apache.org/jira/browse/ARTEMIS-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835856#comment-16835856 ]
ASF subversion and git services commented on ARTEMIS-2323:
----------------------------------------------------------
Commit 5f040cf38bf42f3fc43ae91b37a03e71fea26b61 in activemq-artemis's branch refs/heads/master from Francesco Nigro
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=5f040cf ]
ARTEMIS-2323 NettyTransport should also send requests with void promises
> NettyTransport should also send requests with void promises
> -----------------------------------------------------------
>
> Key: ARTEMIS-2323
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2323
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP, STOMP
> Affects Versions: 2.8.0
> Reporter: Francesco Nigro
> Assignee: Justin Bertram
> Priority: Minor
> Fix For: 2.8.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> AmqpConnection is using NettyTransport::send without making use of ChannelFuture
> return type, but NettyTcpTransport/NettyWSTransport always allocate a new ChannelPromise
> on each call.
> If such ChannelFuture isn't needed (like STOMP does) it would be better to avoid the ChannelPromise instantiation and enhance the API with a proper method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)