[jira] [Comment Edited] (SQOOP-1795) Sqoop2: Retrieve Http post data in plausible manner

["Veena Basavaraj (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223135#comment-14223135 ] 

Veena Basavaraj edited comment on SQOOP-1795 at 11/24/14 5:00 PM:
------------------------------------------------------------------

[~jarcec] The reason why having a wrapper class is one way to solve  is to exactly do the same thing, that is make sure we read and parse once, 

It is not hiding, but guarding our application with surprises.


was (Author: vybs):
[~jarcec] The reason why having a wrapper class is one way to solve  is to exactly do the same thing, that is make sure we read and parse once,

> Sqoop2: Retrieve Http post data in plausible manner
> ---------------------------------------------------
>
>                 Key: SQOOP-1795
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1795
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Qian Xu
>            Assignee: Qian Xu
>            Priority: Minor
>             Fix For: 1.99.5
>
>
> The situation of dealing with the post data is very tricky IMHO. 
> 1. {{getRequest().getReader()}} must be called at the first place. As reading position cannot be reset, you might get unexpected result without notice. SQOOP-1784 is a case of the situation.
> 2. Sqoop client sends post data as a JSON object rather than query string format. Usually it'd suggest to wrap the JSON object as value, and key can be named as "jsonObject". The server will call {{ctx.getParameterValue("jsonObject")}} to get the value.
> I'd suggest to have a {{getRawPostData()}}, so that callers can put finger away from {{getReader()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)