You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/01/25 11:32:35 UTC
[GitHub] qiuchenjian commented on a change in pull request #3104: [HOTFIX]
Fix select query on varchar column with large data fails with jvm crash
qiuchenjian commented on a change in pull request #3104: [HOTFIX] Fix select query on varchar column with large data fails with jvm crash
URL: https://github.com/apache/carbondata/pull/3104#discussion_r250954033
##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/ReusableDataBuffer.java
##########
@@ -47,7 +47,8 @@
*/
public byte[] getDataBuffer(int requestedSize) {
if (dataBuffer == null || requestedSize > size) {
- this.size = requestedSize + ((requestedSize * 30) / 100);
+ this.size = requestedSize + ((requestedSize / 100) * 30);
Review comment:
```suggestion
requestedSize = requestedSize + ((requestedSize / 100) * 30);
```
There is a problem with origin formula
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services