You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/25 03:12:35 UTC
[GitHub] [beam] kennknowles opened a new pull request, #22862: Eliminate null errors from JdbcIO
kennknowles opened a new pull request, #22862:
URL: https://github.com/apache/beam/pull/22862
This adds enough annotation and checks to re-enable nullness checking in JdbcIO. It does not do any significant refactor that might make it less error-prone.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1343263637
Run Java_JDBC_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1238073648
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kileys for label java.
R: @pabloem for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1250939520
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
R: @johnjcasey for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles merged PR #22862:
URL: https://github.com/apache/beam/pull/22862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1253074937
Just noting that I somehow broke `expand()` and haven't narrowed down how, so this is not ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1284538168
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
apilloud commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1284394811
R: @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1271893034
R: @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1279733313
Reminder, please take a look at this pr: @kileys @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1283973117
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @apilloud for label java.
R: @johnjcasey for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1343404958
The spotbugs failure does not reproduce for me locally so I will pull shenanigans to get the report from the jenkins box. We should probably find a way to at least archive the artifacts with the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1343405592
Run Java_JDBC_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
apilloud commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1284392909
r: @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1271513473
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kileys for label java.
R: @pabloem for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1271893259
Setting reviewer so the bot is happy. I need to find some time to fix up the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1260815239
Reminder, please take a look at this pr: @robertwb @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1234196342
Reminder, please take a look at this pr: @lukecwik @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
apilloud commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1284394963
stop reviewer notifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1226740772
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @lukecwik for label java.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1248020233
Reminder, please take a look at this pr: @kileys @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
apilloud commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1284395372
Review bot seems to be having problems...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22862: Eliminate null errors from JdbcIO
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22862:
URL: https://github.com/apache/beam/pull/22862#issuecomment-1343413673
I don't know why spotbugs succeeded locally. There is a multi-statement try-with-resources that I had to annotate to ignore the warning. By grabbing the file off the Jenkins box it was straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org