You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/09/21 14:19:58 UTC
[kudu-CR](branch-1.13.x) Fix Doxygen comment in client.h
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16483
Change subject: Fix Doxygen comment in client.h
......................................................................
Fix Doxygen comment in client.h
Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Reviewed-on: http://gerrit.cloudera.org:8080/16482
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 198372a84c6e2dc8b097eb2d139fa03da7e7b791)
---
M src/kudu/client/client.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/16483/1
--
To view, visit http://gerrit.cloudera.org:8080/16483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Gerrit-Change-Number: 16483
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR](branch-1.13.x) Fix Doxygen comment in client.h
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16483 )
Change subject: Fix Doxygen comment in client.h
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16483/1/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/16483/1/src/kudu/client/client.h@1151
PS1, Line 1151: ///@{
:
> Does this cause doxygen build failure or such?
Yea, I had to change this to be able to build the site as part of the release, but unfortunately, I didn't catch in time before the release was made (I tested the site build after RC1, but I didn't think it was necessary after RC2).
--
To view, visit http://gerrit.cloudera.org:8080/16483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Gerrit-Change-Number: 16483
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Sep 2020 17:57:00 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.13.x) Fix Doxygen comment in client.h
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16483 )
Change subject: Fix Doxygen comment in client.h
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Curious
http://gerrit.cloudera.org:8080/#/c/16483/1/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/16483/1/src/kudu/client/client.h@1151
PS1, Line 1151: ///@{
:
Does this cause doxygen build failure or such?
--
To view, visit http://gerrit.cloudera.org:8080/16483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Gerrit-Change-Number: 16483
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Sep 2020 16:31:16 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.13.x) Fix Doxygen comment in client.h
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16483 )
Change subject: Fix Doxygen comment in client.h
......................................................................
Fix Doxygen comment in client.h
Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Reviewed-on: http://gerrit.cloudera.org:8080/16482
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 198372a84c6e2dc8b097eb2d139fa03da7e7b791)
Reviewed-on: http://gerrit.cloudera.org:8080/16483
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Gerrit-Change-Number: 16483
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.13.x) Fix Doxygen comment in client.h
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Fix Doxygen comment in client.h
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Gerrit-Change-Number: 16483
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.13.x) Fix Doxygen comment in client.h
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16483 )
Change subject: Fix Doxygen comment in client.h
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I945a784c39c2a6c1ea3a628efeba4b7dd3e9f76e
Gerrit-Change-Number: 16483
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Sep 2020 15:22:57 +0000
Gerrit-HasComments: No