You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/10/19 05:20:03 UTC
[GitHub] [submarine] rayray2002 opened a new pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
rayray2002 opened a new pull request #781:
URL: https://github.com/apache/submarine/pull/781
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
Add static type parameter in submarine-sdk
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1045
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
mypy passed
runtime type check
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? Yes/No
* Are there breaking changes for older versions? Yes/No
* Does this need new documentation? Yes/No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 removed a comment on pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
rayray2002 removed a comment on pull request #781:
URL: https://github.com/apache/submarine/pull/781#issuecomment-950450537
> @rayray2002 sorry, could you fix the merge conflict? I will merge it then.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #781:
URL: https://github.com/apache/submarine/pull/781#issuecomment-950106486
Re-post the PR due to previous PR include other commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #781:
URL: https://github.com/apache/submarine/pull/781#issuecomment-950376074
@rayray2002 sorry, could you fix the merge conflict? I will merge it then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #781:
URL: https://github.com/apache/submarine/pull/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #781:
URL: https://github.com/apache/submarine/pull/781#discussion_r734213295
##########
File path: submarine-sdk/pysubmarine/submarine/models/client.py
##########
@@ -37,10 +37,10 @@
class ModelsClient:
def __init__(
self,
- tracking_uri=None,
- registry_uri=None,
- aws_access_key_id=None,
- aws_secret_access_key=None,
+ tracking_uri: str = None,
+ registry_uri: str = None,
+ aws_access_key_id: str = None,
+ aws_secret_access_key: str = None,
Review comment:
we should use typing.Optional[str] when default value is None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #781:
URL: https://github.com/apache/submarine/pull/781#issuecomment-950450537
> @rayray2002 sorry, could you fix the merge conflict? I will merge it then.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #781:
URL: https://github.com/apache/submarine/pull/781#issuecomment-950474044
> @rayray2002 sorry, could you fix the merge conflict? I will merge it then.
Okay I’ll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #781: SUBMARINE-1045. Add static type parameter in submarine-sdk
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #781:
URL: https://github.com/apache/submarine/pull/781#issuecomment-950974738
> @rayray2002 sorry, could you fix the merge conflict? I will merge it then.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org