You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/26 01:38:32 UTC
[GitHub] [spark] sarutak commented on a change in pull request #32652: [SPARK-35501][SQL][TESTS] Add a feature for removing pulled container image for docker integration tests
sarutak commented on a change in pull request #32652:
URL: https://github.com/apache/spark/pull/32652#discussion_r639342223
##########
File path: pom.xml
##########
@@ -264,6 +264,7 @@
<spark.test.home>${session.executionRootDirectory}</spark.test.home>
<spark.test.webdriver.chrome.driver></spark.test.webdriver.chrome.driver>
<spark.test.docker.keepContainer>false</spark.test.docker.keepContainer>
+ <spark.test.docker.removePulledImage>false</spark.test.docker.removePulledImage>
Review comment:
I disabled it by default just for behavior compatibility (pulled images are not removed before this change).
But it may be no problem even if we enable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org