You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/02/16 05:48:19 UTC
[GitHub] [gobblin] srramach opened a new pull request #3469: Use helper-all v0.2.74 to solve issues around default values.
srramach opened a new pull request #3469:
URL: https://github.com/apache/gobblin/pull/3469
The latest version of helper-all fixes the issues seen before w.r.t.
default values, so we can now revert the code and the *.avsc files back
to how they used to be, with two minor exceptions:
1. Check Schema equality using their .toString() representations. Doing
it the old way works for two out of the three instances, but one of
them fails, for reasons I haven't figured out yet.
2. Add a `"default":null` piece to recursive_schema_1_converted.avsc.
This is harmless, and is caused by the fact that the compatibility
helper always adds it if it's a valid default for the schema. See
the comments for FieldBuilder19.setDefault():
https://github.com/linkedin/avro-util/blob/b9e89c55980ea8e5fd3c8d8da362d7195dd2a99c/helper/impls/helper-impl-19/src/main/java/com/linkedin/avroutil1/compatibility/avro19/FieldBuilder19.java#L69
To verify that the files are otherwise the same as before:
```
$ for file in gobblin-core-base/src/test/resources/converter/*.avsc; do
> git show 928e0180c471fc4b7a6caee041b001b5b34e1cc6:$file > /tmp/before
> diff <(jq . </tmp/before) <(jq . <$file)
> done
```
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] sv2000 merged pull request #3469: Use helper-all v0.2.74 to solve issues around default values.
Posted by GitBox <gi...@apache.org>.
sv2000 merged pull request #3469:
URL: https://github.com/apache/gobblin/pull/3469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] sv2000 commented on pull request #3469: Use helper-all v0.2.74 to solve issues around default values.
Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3469:
URL: https://github.com/apache/gobblin/pull/3469#issuecomment-1041901539
Thanks @srramach! LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org