You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "SIDDHARTH TEOTIA (JIRA)" <ji...@apache.org> on 2017/08/01 21:56:00 UTC

[jira] [Updated] (ARROW-1310) Revert ARROW-886

     [ https://issues.apache.org/jira/browse/ARROW-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

SIDDHARTH TEOTIA updated ARROW-1310:
------------------------------------
    Description: 
We don't need to reallocate the underlying offsetVector every time a variable length vector is reallocated. 

Reallocation of offsetVector is taken care of by setSafe() function of the offsetVector. 

The setSafe() function of the Variable Length Vector will decide whether to call realloc() or not. However, this should not decide whether offsetVector needs reallocation or not. When setSafe() calls offsetVector.setSafe(), the latter can decide whether to reallocate the offset vector or not.

  was:
We don't need to reallocate the underlying offsetVector every time a variable length vector is reallocated. 

Reallocation of offsetVector is taken care of by setSafe() function of the offsetVector. 

The setSafe() function of the Variable Length Vector will decide whether to call realloc() or not. However, this should not decide whether offsetVector needs reallocation or not. When setSafe() calls offsetVector.setSafe(), the latter will decide whether to reallocate the vector or not.


> Revert ARROW-886
> ----------------
>
>                 Key: ARROW-1310
>                 URL: https://issues.apache.org/jira/browse/ARROW-1310
>             Project: Apache Arrow
>          Issue Type: Bug
>            Reporter: SIDDHARTH TEOTIA
>            Assignee: SIDDHARTH TEOTIA
>
> We don't need to reallocate the underlying offsetVector every time a variable length vector is reallocated. 
> Reallocation of offsetVector is taken care of by setSafe() function of the offsetVector. 
> The setSafe() function of the Variable Length Vector will decide whether to call realloc() or not. However, this should not decide whether offsetVector needs reallocation or not. When setSafe() calls offsetVector.setSafe(), the latter can decide whether to reallocate the offset vector or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)