You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by hanm <gi...@git.apache.org> on 2017/08/03 03:58:22 UTC

[GitHub] zookeeper pull request #312: ZOOKEEPER-1669: Operations to server will be ti...

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/312#discussion_r131049051
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
    @@ -1001,25 +1010,14 @@ public String toString() {
         @Override
         public void close() {
             synchronized(factory.cnxns){
    --- End diff --
    
    @CheneySun Please let me know if what you think regarding my comment about removing the excessive synchronization here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---