You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrzej Bialecki (JIRA)" <ji...@apache.org> on 2017/10/05 10:47:00 UTC
[jira] [Commented] (SOLR-11413) SolrGraphiteReporter fails to
report metrics due to non-thread safe code
[ https://issues.apache.org/jira/browse/SOLR-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192717#comment-16192717 ]
Andrzej Bialecki commented on SOLR-11413:
------------------------------------------
[~erikpersson] you mentioned the patch includes a unit test that illustrates the problem - but the test is not in the attached patch.
Your proposed fix looks reasonable, but it would be nice to have a test case that illustrates the failure (and the fix).
> SolrGraphiteReporter fails to report metrics due to non-thread safe code
> ------------------------------------------------------------------------
>
> Key: SOLR-11413
> URL: https://issues.apache.org/jira/browse/SOLR-11413
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: 6.6, 7.0
> Reporter: Erik Persson
> Assignee: Andrzej Bialecki
> Attachments: SOLR-11413.patch
>
>
> Symptom:
> Intermittent errors writing graphite metrics. Errors indicate use of sockets which have already been closed.
> Cause:
> SolrGraphiteReporter caches and shares dropwizard Graphite instances. These reporters are not thread safe as they open and close an instance variable of type GraphiteSender. On modern bare metal hardware this problem was observed consistently, and resulted in the majority of metrics failing to be delivered to graphite.
> Proposed Fix:
> Graphite (and PickledGraphite) are not designed to be cached, and should not be.
> Test:
> Patch file includes test which forces error.
> Alternative Fixes Considered:
> * Totally change solr metrics architecture to use a single metrics registry - seems undesirable and impractical
> * Create a synchronized or otherwise thread-safe implementation of dropwizard graphite reporter - should be fixed upstream in dropwizard and not obviously preferred to current model
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org