You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/14 05:35:08 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
nvazquez opened a new pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449
### Description
This PR allows cleaning up nics in case there are nicExpunge commands to be sent
Fixes: #5308
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921059800
<b>Trillian test result (tid-2074)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45303 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2074-kvm-centos7.zip
Smoke tests completed. 87 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_nic | `Error` | 135.33 | test_nic.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3604.60 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 77.05 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#discussion_r709265658
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -667,6 +659,15 @@ protected void advanceExpunge(VMInstanceVO vm) throws ResourceUnavailableExcepti
}
+ private void addAllExpungeCommandsFromList(List<Command> cmdList, Commands cmds, VMInstanceVO vm) {
+ if (CollectionUtils.isNotEmpty(cmdList)) {
Review comment:
Thanks @GutoVeronezi, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-920098877
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921809045
<b>Trillian test result (tid-2101)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35271 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2101-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#discussion_r708502261
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -636,7 +636,7 @@ protected void advanceExpunge(VMInstanceVO vm) throws ResourceUnavailableExcepti
// send hypervisor-dependent commands before removing
final List<Command> finalizeExpungeCommands = hvGuru.finalizeExpunge(vm);
- if (finalizeExpungeCommands != null && finalizeExpungeCommands.size() > 0) {
+ if (CollectionUtils.isNotEmpty(finalizeExpungeCommands) || CollectionUtils.isNotEmpty(nicExpungeCommands)) {
if (hostId != null) {
final Commands cmds = new Commands(Command.OnError.Stop);
for (final Command command : finalizeExpungeCommands) {
Review comment:
Thanks @shwstppr, refactored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921025137
<b>Trillian test result (tid-2075)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41992 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2075-vmware-65u2.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_snapshots_with_removed_data_store | `Error` | 58.26 | test_snapshots.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-920547027
@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-919446931
<b>Trillian test result (tid-2034)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41973 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2034-vmware-65u2.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921050588
<b>Trillian test result (tid-2073)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45062 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2073-xenserver-71.zip
Smoke tests completed. 87 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 101.31 | test_kubernetes_clusters.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 537.73 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918857373
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921419628
@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-919371737
<b>Trillian test result (tid-2033)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35646 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2033-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-920098592
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921845853
<b>Trillian test result (tid-2102)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38439 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2102-vmware-65u2.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#discussion_r708621035
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -667,6 +659,15 @@ protected void advanceExpunge(VMInstanceVO vm) throws ResourceUnavailableExcepti
}
+ private void addAllExpungeCommandsFromList(List<Command> cmdList, Commands cmds, VMInstanceVO vm) {
+ if (CollectionUtils.isNotEmpty(cmdList)) {
Review comment:
We could invert the logic here, to reduce code indentation, and maybe add a log in trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#discussion_r708089450
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -636,7 +636,7 @@ protected void advanceExpunge(VMInstanceVO vm) throws ResourceUnavailableExcepti
// send hypervisor-dependent commands before removing
final List<Command> finalizeExpungeCommands = hvGuru.finalizeExpunge(vm);
- if (finalizeExpungeCommands != null && finalizeExpungeCommands.size() > 0) {
+ if (CollectionUtils.isNotEmpty(finalizeExpungeCommands) || CollectionUtils.isNotEmpty(nicExpungeCommands)) {
if (hostId != null) {
final Commands cmds = new Commands(Command.OnError.Stop);
for (final Command command : finalizeExpungeCommands) {
Review comment:
@nvazquez can you please check if there is a need to check `finalizeExpungeCommands != null` here. With change, this code can be reached when `finalizeExpungeCommands` is null and `nicExpungeCommands` is having items and for KVM `finalizeExpunge` might return null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921419292
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918819785
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918819278
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921413668
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918863101
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-919403342
<b>Trillian test result (tid-2032)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38321 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2032-xenserver-71.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921403117
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921402551
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-920122402
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-919481818
code lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918863599
@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-920546867
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5449:
URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-921858187
<b>Trillian test result (tid-2100)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40294 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5449-t2100-xenserver-71.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_snapshots_with_removed_data_store | `Error` | 55.13 | test_snapshots.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org