You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 16:58:01 UTC

[GitHub] [arrow] jvictorhuguenin opened a new pull request #10367: ARROW-12838: [C++][Gandiva]Fix JNI CI test for gandiva

jvictorhuguenin opened a new pull request #10367:
URL: https://github.com/apache/arrow/pull/10367


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on a change in pull request #10367: ARROW-12838: [Java][Gandiva] Fix JNI CI test for gandiva

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10367:
URL: https://github.com/apache/arrow/pull/10367#discussion_r638370523



##########
File path: java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorTest.java
##########
@@ -1193,7 +1193,7 @@ public void testInExpr() throws GandivaException, Exception {
     Field c1 = Field.nullable("c1", int32);
 
     TreeNode inExpr =
-        TreeBuilder.makeInExpressionInt32(TreeBuilder.makeField(c1), Sets.newHashSet(1, 2, 3, 4, 5, 15, 16));
+            TreeBuilder.makeInExpressionInt32(TreeBuilder.makeField(c1), Sets.newHashSet(1, 2, 3, 4, 5, 15, 16));

Review comment:
       Is this indent style change intentional?
   It seems that we use 4 spaces not 8 spaces for this case in other places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #10367: ARROW-12838: [Java][Gandiva] Fix JNI CI test for gandiva

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10367:
URL: https://github.com/apache/arrow/pull/10367#issuecomment-845906669


   It seems that there are still 3 failures:
   
   https://github.com/apache/arrow/pull/10367/checks?check_run_id=2635803647#step:8:11064
   
   ```text
   Error:  Tests run: 85, Failures: 3, Errors: 0, Skipped: 2
   ```
   
   Could you confirm them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #10367: ARROW-12838: [Java][Gandiva] Fix JNI CI test

Posted by GitBox <gi...@apache.org>.
kou closed pull request #10367:
URL: https://github.com/apache/arrow/pull/10367


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10367: ARROW-12838: [C++][Gandiva]Fix JNI CI test for gandiva

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10367:
URL: https://github.com/apache/arrow/pull/10367#issuecomment-845424185


   https://issues.apache.org/jira/browse/ARROW-12838


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jvictorhuguenin commented on a change in pull request #10367: ARROW-12838: [Java][Gandiva] Fix JNI CI test for gandiva

Posted by GitBox <gi...@apache.org>.
jvictorhuguenin commented on a change in pull request #10367:
URL: https://github.com/apache/arrow/pull/10367#discussion_r638397482



##########
File path: java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorTest.java
##########
@@ -1193,7 +1193,7 @@ public void testInExpr() throws GandivaException, Exception {
     Field c1 = Field.nullable("c1", int32);
 
     TreeNode inExpr =
-        TreeBuilder.makeInExpressionInt32(TreeBuilder.makeField(c1), Sets.newHashSet(1, 2, 3, 4, 5, 15, 16));
+            TreeBuilder.makeInExpressionInt32(TreeBuilder.makeField(c1), Sets.newHashSet(1, 2, 3, 4, 5, 15, 16));

Review comment:
       It was unintentional I'm sorry, my IDE was with a bad configuration, already fixed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jvictorhuguenin commented on pull request #10367: ARROW-12838: [Java][Gandiva] Fix JNI CI test for gandiva

Posted by GitBox <gi...@apache.org>.
jvictorhuguenin commented on pull request #10367:
URL: https://github.com/apache/arrow/pull/10367#issuecomment-847309760


   @kou, I fixed them, one of the tests was considering that null is equal to null in the IN expression query and having an Assertion error
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org