[jira] [Commented] (HIVE-7180) BufferedReader is not closed in MetaStoreSchemaInfo ctor

["Alexander Pivovarov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603939#comment-14603939 ] 

Alexander Pivovarov commented on HIVE-7180:
-------------------------------------------

I do not think we should change constructor signature. Let me fix it

> BufferedReader is not closed in MetaStoreSchemaInfo ctor
> --------------------------------------------------------
>
>                 Key: HIVE-7180
>                 URL: https://issues.apache.org/jira/browse/HIVE-7180
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.13.1
>            Reporter: Ted Yu
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>              Labels: patch
>         Attachments: HIVE-7180.patch, HIVE-7180_001.patch
>
>
> Here is related code:
> {code}
>       BufferedReader bfReader =
>         new BufferedReader(new FileReader(upgradeListFile));
>       String currSchemaVersion;
>       while ((currSchemaVersion = bfReader.readLine()) != null) {
>         upgradeOrderList.add(currSchemaVersion.trim());
> {code}
> BufferedReader / FileReader should be closed upon return from ctor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)