You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eventmesh.apache.org by ch...@apache.org on 2022/08/26 06:57:21 UTC
[incubator-eventmesh] branch master updated: remove unused local variables
This is an automated email from the ASF dual-hosted git repository.
chenguangsheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 18e9af58 remove unused local variables
new 8a64e46f Merge pull request #1171 from horoc/remove-unused-local-variables
18e9af58 is described below
commit 18e9af582d5f03d00078e36233b7b7277fb519cd
Author: horoc <ho...@gmail.com>
AuthorDate: Sun Aug 21 15:42:00 2022 +0800
remove unused local variables
---
.../java/org/apache/eventmesh/protocol/http/HttpProtocolAdaptor.java | 1 -
.../core/protocol/http/processor/BatchSendMessageProcessor.java | 1 -
.../core/protocol/http/processor/LocalSubscribeEventProcessor.java | 2 --
.../core/protocol/http/processor/LocalUnSubscribeEventProcessor.java | 2 --
.../core/protocol/http/processor/RemoteSubscribeEventProcessor.java | 2 --
.../protocol/http/processor/RemoteUnSubscribeEventProcessor.java | 2 --
.../core/protocol/http/processor/SendAsyncEventProcessor.java | 2 --
.../core/protocol/http/processor/SendAsyncRemoteEventProcessor.java | 2 --
.../runtime/core/protocol/tcp/client/session/push/SessionPusher.java | 5 -----
.../runtime/core/protocol/tcp/client/task/MessageTransferTask.java | 1 -
10 files changed, 20 deletions(-)
diff --git a/eventmesh-protocol-plugin/eventmesh-protocol-http/src/main/java/org/apache/eventmesh/protocol/http/HttpProtocolAdaptor.java b/eventmesh-protocol-plugin/eventmesh-protocol-http/src/main/java/org/apache/eventmesh/protocol/http/HttpProtocolAdaptor.java
index ad7ff7f5..1a72ed05 100644
--- a/eventmesh-protocol-plugin/eventmesh-protocol-http/src/main/java/org/apache/eventmesh/protocol/http/HttpProtocolAdaptor.java
+++ b/eventmesh-protocol-plugin/eventmesh-protocol-http/src/main/java/org/apache/eventmesh/protocol/http/HttpProtocolAdaptor.java
@@ -76,7 +76,6 @@ public class HttpProtocolAdaptor<T extends ProtocolTransportObject>
@Override
public ProtocolTransportObject fromCloudEvent(CloudEvent cloudEvent) throws ProtocolHandleException {
- String protocolDesc = cloudEvent.getExtension(Constants.PROTOCOL_DESC).toString();
HttpEventWrapper httpEventWrapper = new HttpEventWrapper();
Map<String, Object> sysHeaderMap = new HashMap<>();
// ce attributes
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java
index 13c0605f..04b00ebb 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java
@@ -172,7 +172,6 @@ public class BatchSendMessageProcessor implements HttpRequestProcessor {
batchId = Objects.requireNonNull(event.getExtension(SendMessageBatchRequestBody.BATCHID)).toString();
producerGroup = Objects.requireNonNull(event.getExtension(SendMessageBatchRequestBody.PRODUCERGROUP)).toString();
- String topic = event.getSubject();
eventSize = Integer.parseInt(Objects.requireNonNull(event.getExtension(SendMessageBatchRequestBody.SIZE)).toString());
CloudEventData eventData = event.getData();
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalSubscribeEventProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalSubscribeEventProcessor.java
index 4c1810f2..899946d9 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalSubscribeEventProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalSubscribeEventProcessor.java
@@ -76,8 +76,6 @@ public class LocalSubscribeEventProcessor extends AbstractEventProcessor impleme
HttpEventWrapper requestWrapper = asyncContext.getRequest();
- HttpEventWrapper responseWrapper;
-
httpLogger.info("uri={}|{}|client2eventMesh|from={}|to={}", requestWrapper.getRequestURI(),
EventMeshConstants.PROTOCOL_HTTP, RemotingHelper.parseChannelRemoteAddr(ctx.channel()), IPUtils.getLocalAddress()
);
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalUnSubscribeEventProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalUnSubscribeEventProcessor.java
index 3f9c858d..d951b69b 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalUnSubscribeEventProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/LocalUnSubscribeEventProcessor.java
@@ -70,8 +70,6 @@ public class LocalUnSubscribeEventProcessor extends AbstractEventProcessor imple
HttpEventWrapper requestWrapper = asyncContext.getRequest();
- HttpEventWrapper responseWrapper;
-
httpLogger.info("uri={}|{}|client2eventMesh|from={}|to={}", requestWrapper.getRequestURI(),
EventMeshConstants.PROTOCOL_HTTP,
RemotingHelper.parseChannelRemoteAddr(ctx.channel()), IPUtils.getLocalAddress());
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteSubscribeEventProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteSubscribeEventProcessor.java
index f1a9d9c3..c47b8b60 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteSubscribeEventProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteSubscribeEventProcessor.java
@@ -81,8 +81,6 @@ public class RemoteSubscribeEventProcessor extends AbstractEventProcessor implem
HttpEventWrapper requestWrapper = asyncContext.getRequest();
- HttpEventWrapper responseWrapper;
-
httpLogger.info("uri={}|{}|client2eventMesh|from={}|to={}", requestWrapper.getRequestURI(),
EventMeshConstants.PROTOCOL_HTTP, RemotingHelper.parseChannelRemoteAddr(ctx.channel()), IPUtils.getLocalAddress()
);
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteUnSubscribeEventProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteUnSubscribeEventProcessor.java
index 9c3d9ff7..70ca69b6 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteUnSubscribeEventProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteUnSubscribeEventProcessor.java
@@ -79,8 +79,6 @@ public class RemoteUnSubscribeEventProcessor extends AbstractEventProcessor impl
HttpEventWrapper requestWrapper = asyncContext.getRequest();
- HttpEventWrapper responseWrapper;
-
httpLogger.info("uri={}|{}|client2eventMesh|from={}|to={}", requestWrapper.getRequestURI(),
EventMeshConstants.PROTOCOL_HTTP, RemotingHelper.parseChannelRemoteAddr(ctx.channel()), IPUtils.getLocalAddress()
);
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncEventProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncEventProcessor.java
index 51076199..54ca29e9 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncEventProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncEventProcessor.java
@@ -81,8 +81,6 @@ public class SendAsyncEventProcessor implements AsyncHttpProcessor {
HttpEventWrapper requestWrapper = asyncContext.getRequest();
- HttpEventWrapper responseWrapper;
-
httpLogger.info("uri={}|{}|client2eventMesh|from={}|to={}", requestWrapper.getRequestURI(),
EventMeshConstants.PROTOCOL_HTTP, RemotingHelper.parseChannelRemoteAddr(ctx.channel()), IPUtils.getLocalAddress());
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncRemoteEventProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncRemoteEventProcessor.java
index 9d1eb94a..149c657e 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncRemoteEventProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncRemoteEventProcessor.java
@@ -85,8 +85,6 @@ public class SendAsyncRemoteEventProcessor implements AsyncHttpProcessor {
HttpEventWrapper requestWrapper = asyncContext.getRequest();
- HttpEventWrapper responseWrapper;
-
httpLogger.info("uri={}|{}|client2eventMesh|from={}|to={}", requestWrapper.getRequestURI(),
EventMeshConstants.PROTOCOL_HTTP, RemotingHelper.parseChannelRemoteAddr(ctx.channel()), IPUtils.getLocalAddress());
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/SessionPusher.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/SessionPusher.java
index f3680638..5f905707 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/SessionPusher.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/SessionPusher.java
@@ -99,9 +99,6 @@ public class SessionPusher {
.withExtension(EventMeshConstants.RSP_IDC, session.getClient().getIdc())
.withExtension(EventMeshConstants.RSP_IP, session.getClient().getHost())
.build();
- EventMeshMessage body = null;
- int retCode = 0;
- String retMsg = null;
try {
pkg = (Package) protocolAdaptor.fromCloudEvent(downStreamMsgContext.event);
pkg.setHeader(new Header(cmd, OPStatus.SUCCESS.getCode(), null, downStreamMsgContext.seq));
@@ -109,8 +106,6 @@ public class SessionPusher {
messageLogger.info("pkg|mq2eventMesh|cmd={}|mqMsg={}|user={}", cmd, pkg, session.getClient());
} catch (Exception e) {
pkg.setHeader(new Header(cmd, OPStatus.FAIL.getCode(), e.getStackTrace().toString(), downStreamMsgContext.seq));
- retCode = -1;
- retMsg = e.toString();
} finally {
session.getClientGroupWrapper().get().getEventMeshTcpMonitor().getTcpSummaryMetrics().getEventMesh2clientMsgNum().incrementAndGet();
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
index cb249a0c..ff8f91ca 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
@@ -93,7 +93,6 @@ public class MessageTransferTask extends AbstractTask {
Command replyCmd = getReplyCmd(cmd);
Package msg = new Package();
- int retCode = 0;
EventMeshTcpSendResult sendStatus;
CloudEvent event = null;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org