You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by dyanarose <gi...@git.apache.org> on 2016/05/26 20:52:47 UTC
[GitHub] flink pull request: [FLINK-3975] [docs] Override baseurl when serv...
GitHub user dyanarose opened a pull request:
https://github.com/apache/flink/pull/2040
[FLINK-3975] [docs] Override baseurl when serving docs locally
Updating build_docs.sh to serve the docs locally with the correct url.
This change makes build_docs.sh run the equivalent serve command to build_docs.bat.
removing now unnecessary config file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dyanarose/flink FLINK-3975
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2040.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2040
----
commit 96af1da4e4770f2e6ed18d8413a6ea106927606e
Author: Dyana Rose <dy...@gmail.com>
Date: 2016-05-26T20:40:07Z
[FLINK-3975] [docs] Override baseurl when serving docs locally
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3975] [docs] Override baseurl when serv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2040
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3975] [docs] Override baseurl when serv...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2040#discussion_r65138587
--- Diff: docs/build_docs.sh ---
@@ -54,7 +54,7 @@ JEKYLL_CMD="build"
while getopts ":p" opt; do
case $opt in
p)
- JEKYLL_CMD="serve --config _config.yml,_local_preview_conf.yml --watch"
+ JEKYLL_CMD="serve --baseurl= --watch"
--- End diff --
Thanks for the explanation :-) I'll merge this later today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3975] [docs] Override baseurl when serv...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2040#discussion_r65107320
--- Diff: docs/build_docs.sh ---
@@ -54,7 +54,7 @@ JEKYLL_CMD="build"
while getopts ":p" opt; do
case $opt in
p)
- JEKYLL_CMD="serve --config _config.yml,_local_preview_conf.yml --watch"
+ JEKYLL_CMD="serve --baseurl= --watch"
--- End diff --
Thanks! Just tried this out and it works as expected. I guess it was there, because older Jekyll versions didn't have support for this. @dyanarose, do know exactly what changed (if anything) between Jekyll versions?
+1 to apply this change after #2033 has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3975] [docs] Override baseurl when serv...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/2040#issuecomment-222535280
@uce Can you have a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3975] [docs] Override baseurl when serv...
Posted by dyanarose <gi...@git.apache.org>.
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/2040#discussion_r65137533
--- Diff: docs/build_docs.sh ---
@@ -54,7 +54,7 @@ JEKYLL_CMD="build"
while getopts ":p" opt; do
case $opt in
p)
- JEKYLL_CMD="serve --config _config.yml,_local_preview_conf.yml --watch"
+ JEKYLL_CMD="serve --baseurl= --watch"
--- End diff --
@uce It looks like the `baseurl` switch came in with 1.0 https://github.com/jekyll/jekyll/blob/0ee1a75d16265abc250d0747c5f93bf2ad2daa05/site/_docs/upgrading/0-to-2.md#baseurl.
I think `serve` not respecting the multiple config files may be a bug/feature with Jekyll as the docs say that `serve` takes all the same switches as `build` does. https://jekyllrb.com/docs/configuration/#serve-command-options. I'm looking to prove that when I get the chance and look into it to raise an issue to see if the code or the docs need changing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---