You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2010/12/14 21:39:05 UTC
DO NOT REPLY [Bug 50475] New: Introduction of a Test Fragment Test
Element for a better Include flow
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Summary: Introduction of a Test Fragment Test Element for a
better Include flow
Product: JMeter
Version: 2.3.4
Platform: Macintosh
Status: NEW
Severity: enhancement
Priority: P2
Component: Main
AssignedTo: notifications@jakarta.apache.org
ReportedBy: ansoni@gmail.com
Created an attachment (id=26403)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26403)
testFragment Patch of MenuFactory, TestPlan and IncludeController to support
this enhancement
The Include and Module controller logic currently has some bad user flows.
Here is the main one I see:
User Flow: Update Include File
1. Open Existing Include File
-- Contained Element is automatically added to WorkBench
2. Edit File
3. Click on desired Node
4. File->Save Selection As
5. Rename file if needed(it takes the name of the Node()
6. Overwrite Existing? -> Yes
This overly complicated flow is introduced because Include-type JMX files are
second-rate citizens. They are not part of a Test Plan so they cannot be
automatically saved with Ctrl+S. Also, since they cannot contain any save-able
Thread Groups, they have to be debugged with another Test Plan that imports it.
This is another bad user-flow.
Enhancement: Introduce a sub-TestPlan Test Element named Test Fragment that
can be used for holding non-executing trees.
This element behaves like the Thread Group except that it doesn't execute
during a Run->Start. Since it exists underneath the Test Plan element, it can
be saved in the more natural flow preventing users from accidentally
over-writing their include file with a blank Test Plan. The IncludeController
would be enhanced to support importing these Test Fragments while maintaining
support for the non-Test Plan JMX files that already exist.
A side-affect of this change is that a user could also create a Thread Group
for the Include File that can Regress the Test Fragment logic by simply using
the ModuleController to run the Test Fragment Tree.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26403|application/octet-stream |text/plain
mime type| |
Attachment #26403|0 |1
is patch| |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
--- Comment #6 from ansoni@gmail.com 2010-12-15 14:20:02 EST ---
The instanceof portions were left-over from the re-use of an existing
component. No missing code... they can just be removed.
I will update the component_reference.xml and attach shortly.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
--- Comment #1 from ansoni@gmail.com 2010-12-14 15:40:08 EST ---
Created an attachment (id=26404)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26404)
Test Fragment Controller Object
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
--- Comment #2 from ansoni@gmail.com 2010-12-14 15:40:50 EST ---
Created an attachment (id=26405)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26405)
TestFragmentControllerGUI Object
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
--- Comment #5 from Sebb <se...@apache.org> 2010-12-15 12:49:54 EST ---
Forgot to mention - it would be useful to have a documentation patch for
component_reference.xml if at all possible.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26405|TestFragmentControllerGUI |TestFragmentControllerGUI.j
description|Object |ava
Attachment #26405|application/octet-stream |text/plain
mime type| |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #9 from Sebb <se...@apache.org> 2010-12-15 22:10:35 EST ---
Thanks very much. Patches applied with a few minor tweaks:
URL: http://svn.apache.org/viewvc?rev=1049771&view=rev
Log:
Bug 50475 - Introduction of a Test Fragment Test Element for a better Include
flow
Added:
jakarta/jmeter/trunk/docs/images/screenshots/test_fragment.png (with
props)
jakarta/jmeter/trunk/src/components/org/apache/jmeter/control/TestFragmentController.java
(with props)
jakarta/jmeter/trunk/src/components/org/apache/jmeter/control/gui/TestFragmentControllerGui.java
(with props)
jakarta/jmeter/trunk/xdocs/images/screenshots/test_fragment.png (with
props)
Modified:
jakarta/jmeter/trunk/bin/saveservice.properties
jakarta/jmeter/trunk/src/components/org/apache/jmeter/control/IncludeController.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/control/gui/TestPlanGui.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
jakarta/jmeter/trunk/xdocs/changes.xml
jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml
jakarta/jmeter/trunk/xdocs/usermanual/test_plan.xml
Code will be in nightly builds from r1049771
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
OS/Version| |All
--- Comment #4 from Sebb <se...@apache.org> 2010-12-15 12:47:15 EST ---
I've had a look at the patch. It seems to work well, and does not appear to
affect existing test plans.
However, there are some odd bits of code that don't appear to do anything in
the TestFragmentControllerGui class:
if (element instanceof TestFragmentController) {
TestFragmentController testFragmentController =
(TestFragmentController) element;
}
and
if (controller instanceof TestFragmentController) {
}
Is there some code missing here? Or should these code snippets be removed?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26412|application/octet-stream |text/plain
mime type| |
Attachment #26412|0 |1
is patch| |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26404|application/octet-stream |text/plain
mime type| |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
--- Comment #3 from ansoni@gmail.com 2010-12-14 15:41:54 EST ---
Created an attachment (id=26406)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26406)
Screenshot showing how this would exist in the Test Plan Tree
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
ansoni@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #8 from ansoni@gmail.com 2010-12-15 15:11:53 EST ---
Document patch attached. New Section added in the test_plan.xml to give an
overview of the Test Fragment Element and the Include Controller section
updated to reflect the new flow.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
--- Comment #7 from ansoni@gmail.com 2010-12-15 15:08:50 EST ---
Created an attachment (id=26412)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26412)
user_manual patches for test_plan and component_reference
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50475] Introduction of a Test Fragment Test
Element for a better Include flow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50475
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26404|Test Fragment Controller |TestFragmentController.java
description|Object |
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org