You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/06/08 11:06:58 UTC

[Bug 122497] New: Can't drag gallery to in Calc on Mac

https://issues.apache.org/ooo/show_bug.cgi?id=122497

            Bug ID: 122497
        Issue Type: DEFECT
           Summary: Can't drag gallery to in Calc on Mac
           Product: Writer
           Version: AOO400-dev
          Hardware: Mac
                OS: Mac OSX, 10.8
            Status: CONFIRMED
          Severity: critical
          Priority: P3
         Component: editing
          Assignee: issues@openoffice.apache.org
          Reporter: doneyourself@gmail.com
                CC: issues@openoffice.apache.org

Build :AOO400m2(Build:9701)  -  Rev. 1489073
on Mac OS

Step:
1. New a spreadsheet
2. Drag picture from gallery

Issue:
Fail to add picture by dragging

In writer and presentation on Mac ,it passed
In Calc on Windows7 ,it passed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

liupingtan <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #11 from liupingtan <do...@gmail.com> ---
Verify on Mac on Rev. 1499347

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

4.0.0_release_blocker granted: [Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
jsc@apache.org has granted liupingtan <do...@gmail.com>'s request for
4.0.0_release_blocker:
Bug 122497: Can't drag gallery to in Calc on Mac
https://issues.apache.org/ooo/show_bug.cgi?id=122497


------- Additional Comments from jsc@apache.org
grant showstopper flag, fixed already

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked commited change on win, looks well, done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com

--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
ALG: Taking a look. Indeed, simple drag on mac in calc shows the symbol that
indicates that the D&D is not accepted. Pressing CTRL+SHIFT works, and D&D on
existing draw objects (holding CTRL+ALT) works, too. Taking a look...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
ALG: On mac SystemToOfficeDragActions is used to convert between mac D&D
actions and ::com::sun::star::datatransfer::dnd::DNDConstants. This method
shows why a '5' is set in ScGridWindow::AcceptDrop in nMyAction; the value is a
flag-value, not a numerical one. Thus the switch/case in
ScGridWindow::AcceptDrop is basically wrong, but has to use the values as flag
values. I am only curious why this ever had worked; maybe DND_ACTION_LINK was
added in the near past somehow...?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

liupingtan <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |4.0.0_release_blocker?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked in sd, mnAction is handled as flag values. Sw is using a mix of
comparisons and flag handling, (hopefully) filtering everywhere before usage as
needed. Adapting code in Sc to handle as flag values, too...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
LG: Also checked on linux, looks good, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hdu@apache.org

--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: Adding hdu to cc, he may know more if in the close past the mac D&D
actions might have expanded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsc@apache.org
              Flags|4.0.0_release_blocker?      |4.0.0_release_blocker+

--- Comment #10 from jsc@apache.org ---
grant showstopper flag, fixed already

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
ALG: Added filtering to ScGridWindow::ExecuteDrop, added handling to have
direct D&D for objects. Checking on other plattforms...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awf.aoo@googlemail.com

--- Comment #1 from Andre <aw...@googlemail.com> ---
The Calc edit view does not accept the gallery graphic.  The graphic can still
be inserted via the context menu (Insert -> Copy).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED

--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
ALG: Pressing any of the qualifier keys CTRL, ALT or CMD, makes it work.
Checked GalleryTransferable::AddSupportedFormats, the correct formats are
added. Checked ScGridWindow::AcceptDrop, the correct actions arrive, but
nMyAction (and thus rEvt.mnAction) is on '5' which is wrong. Allowed values are
from ::com::sun::star::datatransfer::dnd::DNDConstants and allow 0..4 and 0x80.
Need to check how this happens (probably on the system-dependent side of
things)...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122497] Can't drag gallery to in Calc on Mac

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122497

liupingtan <do...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|editing                     |editing
            Product|Writer                      |Calc
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.