You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/22 23:38:19 UTC
Review Request 67256: Added a unit test for CSI plugin RPC metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67256/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
This patch adds the `ROOT_CsiPluginRpcMetrics` test that issues a
`CREATE_VOLUME` followed by a `DESTROY_VOLUME`, which would fail due to
an out-of-band deletion of the actual volume.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp 45cb38922f78941e82667a60b3b71ce220c9202f
Diff: https://reviews.apache.org/r/67256/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67256: Added a unit test for CSI plugin RPC
metrics.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67256/#review204147
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 25, 2018, 12:24 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67256/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 12:24 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8943
> https://issues.apache.org/jira/browse/MESOS-8943
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the `ROOT_CsiPluginRpcMetrics` test that issues a
> `CREATE_VOLUME` followed by a `DESTROY_VOLUME`, which would fail due to
> an out-of-band deletion of the actual volume.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 45cb38922f78941e82667a60b3b71ce220c9202f
>
>
> Diff: https://reviews.apache.org/r/67256/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67256: Added a unit test for CSI plugin RPC
metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67256/
-----------------------------------------------------------
(Updated June 1, 2018, 12:47 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Fixed a flakiness due to a race between offers and test teardown.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
This patch adds the `ROOT_CsiPluginRpcMetrics` test that issues a
`CREATE_VOLUME` followed by a `DESTROY_VOLUME`, which would fail due to
an out-of-band deletion of the actual volume.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 04a75fc4d53d1b7211e64755097b06b1e68cc3b3
Diff: https://reviews.apache.org/r/67256/diff/3/
Changes: https://reviews.apache.org/r/67256/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67256: Added a unit test for CSI plugin RPC
metrics.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67256/
-----------------------------------------------------------
(Updated May 25, 2018, 12:24 a.m.)
Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
Changes
-------
Renamed the `discarded` metric to `cancelled`.
Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943
Repository: mesos
Description
-------
This patch adds the `ROOT_CsiPluginRpcMetrics` test that issues a
`CREATE_VOLUME` followed by a `DESTROY_VOLUME`, which would fail due to
an out-of-band deletion of the actual volume.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 45cb38922f78941e82667a60b3b71ce220c9202f
Diff: https://reviews.apache.org/r/67256/diff/2/
Changes: https://reviews.apache.org/r/67256/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao