You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 10:49:01 UTC
[GitHub] [spark] beliefer opened a new pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
beliefer opened a new pull request #32107:
URL: https://github.com/apache/spark/pull/32107
### What changes were proposed in this pull request?
Extend the `Sum` expression to to support `DayTimeIntervalType` and `YearMonthIntervalType` added by #31614.
Note: the expressions can throw the overflow exception independently from the SQL config `spark.sql.ansi.enabled`. In this way, the modified expressions always behave in the ANSI mode for the intervals.
### Why are the changes needed?
Extend `org.apache.spark.sql.catalyst.expressions.aggregate.Sum` to support `DayTimeIntervalType` and `YearMonthIntervalType`.
### Does this PR introduce _any_ user-facing change?
'No'.
Should not since new types have not been released yet.
### How was this patch tested?
Jenkins test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818479722
**[Test build #137280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137280/testReport)** for PR 32107 at commit [`9b8c461`](https://github.com/apache/spark/commit/9b8c4614544c5be1d8a0b08a8a8265d2b932ca50).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817240215
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41751/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821997917
**[Test build #137530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137530/testReport)** for PR 32107 at commit [`d022492`](https://github.com/apache/spark/commit/d0224926ee599bb65fc4ba728a7048cfbdbf5622).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class VectorizedBLAS extends F2jBLAS `
* `class PandasOnSparkFrameMethods(object):`
* `class PandasOnSparkSeriesMethods(object):`
* `class PandasOnSparkPlotAccessor(PandasObject):`
* `class PandasOnSparkBarPlot(PandasBarPlot, TopNPlotBase):`
* `class PandasOnSparkBoxPlot(PandasBoxPlot, BoxPlotBase):`
* `class PandasOnSparkHistPlot(PandasHistPlot, HistogramPlotBase):`
* `class PandasOnSparkPiePlot(PandasPiePlot, TopNPlotBase):`
* `class PandasOnSparkAreaPlot(PandasAreaPlot, SampledPlotBase):`
* `class PandasOnSparkLinePlot(PandasLinePlot, SampledPlotBase):`
* `class PandasOnSparkBarhPlot(PandasBarhPlot, TopNPlotBase):`
* `class PandasOnSparkScatterPlot(PandasScatterPlot, TopNPlotBase):`
* `class PandasOnSparkKdePlot(PandasKdePlot, KdePlotBase):`
* `class PandasOnSparkUsageLogger(object):`
* `case class KnownFloatingPointNormalized(child: Expression) extends TaggingExpression `
* `case class Acos(child: Expression) extends UnaryMathExpression(math.acos, \"ACOS\") `
* `case class Asin(child: Expression) extends UnaryMathExpression(math.asin, \"ASIN\") `
* `case class Atan(child: Expression) extends UnaryMathExpression(math.atan, \"ATAN\") `
* `case class Cbrt(child: Expression) extends UnaryMathExpression(math.cbrt, \"CBRT\") `
* `case class Cos(child: Expression) extends UnaryMathExpression(math.cos, \"COS\") `
* `case class Cosh(child: Expression) extends UnaryMathExpression(math.cosh, \"COSH\") `
* `case class Log10(child: Expression) extends UnaryLogExpression(StrictMath.log10, \"LOG10\") `
* `case class Signum(child: Expression) extends UnaryMathExpression(math.signum, \"SIGNUM\") `
* `case class Sin(child: Expression) extends UnaryMathExpression(math.sin, \"SIN\") `
* `case class Sinh(child: Expression) extends UnaryMathExpression(math.sinh, \"SINH\") `
* `case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, \"SQRT\") `
* `case class Tan(child: Expression) extends UnaryMathExpression(math.tan, \"TAN\") `
* `case class Tanh(child: Expression) extends UnaryMathExpression(math.tanh, \"TANH\") `
* `trait AnalysisOnlyCommand extends Command `
* `case class DeleteAction(condition: Option[Expression]) extends MergeAction `
* `case class RefreshTable(child: LogicalPlan) extends UnaryCommand `
* `case class CommentOnNamespace(child: LogicalPlan, comment: String) extends UnaryCommand `
* `case class CommentOnTable(child: LogicalPlan, comment: String) extends UnaryCommand `
* `case class RefreshFunction(child: LogicalPlan) extends UnaryCommand `
* `case class DescribeFunction(child: LogicalPlan, isExtended: Boolean) extends UnaryCommand `
* `case class RecoverPartitions(child: LogicalPlan) extends UnaryCommand `
* `case class RuleId(id: Int) `
* `abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product with TreePatternBits `
* `trait TreePatternBits `
* ` implicit class MetadataColumnHelper(attr: Attribute) `
* `case class SetCommand(kv: Option[(String, Option[String])])`
* `case class ResetCommand(config: Option[String]) extends LeafRunnableCommand with IgnoreCachedData `
* `case class AddJarCommand(path: String) extends LeafRunnableCommand `
* `case class AddFileCommand(path: String) extends LeafRunnableCommand `
* `case class AddArchiveCommand(path: String) extends LeafRunnableCommand `
* `case class ListFilesCommand(files: Seq[String] = Seq.empty[String]) extends LeafRunnableCommand `
* `case class ListJarsCommand(jars: Seq[String] = Seq.empty[String]) extends LeafRunnableCommand `
* `case class ListArchivesCommand(archives: Seq[String] = Seq.empty[String])`
* `abstract class DescribeCommandBase extends LeafRunnableCommand `
* `case class WriteToDataSourceV2(`
* `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class WriteToMicroBatchDataSource(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816613110
**[Test build #137131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137131/testReport)** for PR 32107 at commit [`d1373fb`](https://github.com/apache/spark/commit/d1373fb38d9350e508cab31e2d7aa83403273c5b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820015682
**[Test build #137390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137390/testReport)** for PR 32107 at commit [`01effb8`](https://github.com/apache/spark/commit/01effb8484723af55905ecab2a95b85e6b23fb48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819489217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818711222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41870/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819568689
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820015682
**[Test build #137390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137390/testReport)** for PR 32107 at commit [`01effb8`](https://github.com/apache/spark/commit/01effb8484723af55905ecab2a95b85e6b23fb48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821970483
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42104/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816641514
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821970962
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42104/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818555380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818595794
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137270/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821944756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32107:
URL: https://github.com/apache/spark/pull/32107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818406430
**[Test build #137270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137270/testReport)** for PR 32107 at commit [`a5bf107`](https://github.com/apache/spark/commit/a5bf10723dc128274effd3f347b469ee528a0fb3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821944908
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818595794
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137270/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817260575
**[Test build #137173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137173/testReport)** for PR 32107 at commit [`7897af4`](https://github.com/apache/spark/commit/7897af450ab3870a1af747feb776ebf43d913767).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817240614
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41751/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816636160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820033617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41967/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-822004019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137530/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-822004019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137530/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #32107:
URL: https://github.com/apache/spark/pull/32107#discussion_r612091158
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1110,6 +1112,14 @@ class DataFrameAggregateSuite extends QueryTest
val e = intercept[AnalysisException](arrayDF.groupBy(struct($"col.a")).count())
assert(e.message.contains("requires integral type"))
}
+
+ test("SPARK-34716: Support ANSI SQL intervals by the aggregate function `sum`") {
Review comment:
For the third suggestion, If we support intervals in SQL, we will add new test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820030936
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41967/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820132545
@HyukjinKwon Should this be rebased/merged on the master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818711222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41870/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819489264
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41926/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816614319
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137131/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818406430
**[Test build #137270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137270/testReport)** for PR 32107 at commit [`a5bf107`](https://github.com/apache/spark/commit/a5bf10723dc128274effd3f347b469ee528a0fb3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821951030
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42103/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820011010
**[Test build #747608412](https://github.com/beliefer/spark/actions/runs/747608412)** for PR 32107 at commit [`01effb8`](https://github.com/beliefer/spark/commit/01effb8484723af55905ecab2a95b85e6b23fb48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819451610
**[Test build #137347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137347/testReport)** for PR 32107 at commit [`18c17ff`](https://github.com/apache/spark/commit/18c17ffa6848575cd589635b4b730a80056b57f7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818665430
**[Test build #137290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137290/testReport)** for PR 32107 at commit [`a4d1214`](https://github.com/apache/spark/commit/a4d1214ecc3f7ab846ba043b78d77fda2353f014).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819544554
**[Test build #137347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137347/testReport)** for PR 32107 at commit [`18c17ff`](https://github.com/apache/spark/commit/18c17ffa6848575cd589635b4b730a80056b57f7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818454330
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41849/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818665430
**[Test build #137290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137290/testReport)** for PR 32107 at commit [`a4d1214`](https://github.com/apache/spark/commit/a4d1214ecc3f7ab846ba043b78d77fda2353f014).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819682673
**[Test build #747608412](https://github.com/beliefer/spark/actions/runs/747608412)** for PR 32107 at commit [`18c17ff`](https://github.com/beliefer/spark/commit/18c17ffa6848575cd589635b4b730a80056b57f7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818711153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816614319
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137131/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-822138460
@MaxGekk Thanks for your review. @HyukjinKwon Thanks for your help too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819451610
**[Test build #137347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137347/testReport)** for PR 32107 at commit [`18c17ff`](https://github.com/apache/spark/commit/18c17ffa6848575cd589635b4b730a80056b57f7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820151088
**[Test build #137390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137390/testReport)** for PR 32107 at commit [`01effb8`](https://github.com/apache/spark/commit/01effb8484723af55905ecab2a95b85e6b23fb48).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818454330
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41849/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820158712
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137390/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818785155
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137290/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32107:
URL: https://github.com/apache/spark/pull/32107#discussion_r611147008
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1110,6 +1112,14 @@ class DataFrameAggregateSuite extends QueryTest
val e = intercept[AnalysisException](arrayDF.groupBy(struct($"col.a")).count())
assert(e.message.contains("requires integral type"))
}
+
+ test("SPARK-34716: Support ANSI SQL intervals by the aggregate function `sum`") {
Review comment:
Could you test more cases:
1. Negative tests such as overflow
2. Aggregate nulls and non-nulls
3. Looking at https://github.com/apache/spark/pull/26325, we will need to add more tests as soon as we support construction of the intervals in SQL via cast or `make_interval`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1110,6 +1112,14 @@ class DataFrameAggregateSuite extends QueryTest
val e = intercept[AnalysisException](arrayDF.groupBy(struct($"col.a")).count())
assert(e.message.contains("requires integral type"))
}
+
+ test("SPARK-34716: Support ANSI SQL intervals by the aggregate function `sum`") {
+ val df = Seq((Period.ofMonths(10), Duration.ofDays(10)),
+ (Period.ofMonths(1), Duration.ofDays(1)))
+ .toDF("year-month", "day-time")
+ val sumDF = df.select(sum($"year-month"), sum($"day-time"))
+ checkAnswer(sumDF, Row(Period.ofMonths(11), Duration.ofDays(11)))
Review comment:
You modified the `resultType` but don't check the type in schema. Could you add such check, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817236404
**[Test build #137173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137173/testReport)** for PR 32107 at commit [`7897af4`](https://github.com/apache/spark/commit/7897af450ab3870a1af747feb776ebf43d913767).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818454292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817240614
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41751/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821950523
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42103/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818575206
**[Test build #137270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137270/testReport)** for PR 32107 at commit [`a5bf107`](https://github.com/apache/spark/commit/a5bf10723dc128274effd3f347b469ee528a0fb3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821979588
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137529/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817239800
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41751/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821944984
**[Test build #137529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137529/testReport)** for PR 32107 at commit [`01effb8`](https://github.com/apache/spark/commit/01effb8484723af55905ecab2a95b85e6b23fb48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821965807
**[Test build #137530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137530/testReport)** for PR 32107 at commit [`d022492`](https://github.com/apache/spark/commit/d0224926ee599bb65fc4ba728a7048cfbdbf5622).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32107:
URL: https://github.com/apache/spark/pull/32107#discussion_r611116008
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -17,10 +17,11 @@
package org.apache.spark.sql
+import java.time.{Duration, Period}
+
import scala.util.Random
import org.scalatest.matchers.must.Matchers.the
Review comment:
```suggestion
import org.scalatest.matchers.must.Matchers.the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816641514
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818479722
**[Test build #137280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137280/testReport)** for PR 32107 at commit [`9b8c461`](https://github.com/apache/spark/commit/9b8c4614544c5be1d8a0b08a8a8265d2b932ca50).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819489264
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41926/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820095715
Just curious. Does other DBMSes support aggregation on such interval types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #32107:
URL: https://github.com/apache/spark/pull/32107#discussion_r612088888
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1110,6 +1112,14 @@ class DataFrameAggregateSuite extends QueryTest
val e = intercept[AnalysisException](arrayDF.groupBy(struct($"col.a")).count())
assert(e.message.contains("requires integral type"))
}
+
+ test("SPARK-34716: Support ANSI SQL intervals by the aggregate function `sum`") {
Review comment:
For your first suggestion. I think we should not add the negative tests. Because we have the negative tests for `Add`. Sum(int), Sum(decimal) not add the negative tests, because they depend the robust of `Add`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-822005686
+1, LGTM. Merging to master.
Thank you, @beliefer .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821965807
**[Test build #137530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137530/testReport)** for PR 32107 at commit [`d022492`](https://github.com/apache/spark/commit/d0224926ee599bb65fc4ba728a7048cfbdbf5622).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820033617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41967/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821944984
**[Test build #137529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137529/testReport)** for PR 32107 at commit [`01effb8`](https://github.com/apache/spark/commit/01effb8484723af55905ecab2a95b85e6b23fb48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818398524
> @beliefer Could you add more tests, please. For example, look at the tests which the PR #27619 removed:
>
> * checks in ExpressionTypeCheckingSuite
> * `test("calendar interval agg support hash aggregate")`
In fact, sum uses sort aggregate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818555315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820032438
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41967/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817262970
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137173/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818398524
> @beliefer Could you add more tests, please. For example, look at the tests which the PR #27619 removed:
>
> * checks in ExpressionTypeCheckingSuite
> * `test("calendar interval agg support hash aggregate")`
In fact, sum uses sort aggregate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821948142
@beliefer Could you rebase/merge on master. This will trigger GitHub actions. FYI, jenkins job doesn't run all checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818555315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818785155
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137290/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817236404
**[Test build #137173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137173/testReport)** for PR 32107 at commit [`7897af4`](https://github.com/apache/spark/commit/7897af450ab3870a1af747feb776ebf43d913767).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817262970
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137173/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821972280
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42104/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818554851
**[Test build #137280 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137280/testReport)** for PR 32107 at commit [`9b8c461`](https://github.com/apache/spark/commit/9b8c4614544c5be1d8a0b08a8a8265d2b932ca50).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816613110
**[Test build #137131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137131/testReport)** for PR 32107 at commit [`d1373fb`](https://github.com/apache/spark/commit/d1373fb38d9350e508cab31e2d7aa83403273c5b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821972280
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42104/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820158712
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137390/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-817240370
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821979588
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137529/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821951030
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42103/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821944756
Because https://github.com/apache/spark/pull/32212/ merged
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-819568689
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-818754678
**[Test build #137290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137290/testReport)** for PR 32107 at commit [`a4d1214`](https://github.com/apache/spark/commit/a4d1214ecc3f7ab846ba043b78d77fda2353f014).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #32107:
URL: https://github.com/apache/spark/pull/32107#discussion_r612088888
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1110,6 +1112,14 @@ class DataFrameAggregateSuite extends QueryTest
val e = intercept[AnalysisException](arrayDF.groupBy(struct($"col.a")).count())
assert(e.message.contains("requires integral type"))
}
+
+ test("SPARK-34716: Support ANSI SQL intervals by the aggregate function `sum`") {
Review comment:
For your first suggestion. I think we should not add the negative tests. Because we have the negative tests for `Add`. Sum(int), Sum(decimal) not add the negative tests, because they depend the robust of `Add`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-816614294
**[Test build #137131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137131/testReport)** for PR 32107 at commit [`d1373fb`](https://github.com/apache/spark/commit/d1373fb38d9350e508cab31e2d7aa83403273c5b).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821975596
**[Test build #137529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137529/testReport)** for PR 32107 at commit [`01effb8`](https://github.com/apache/spark/commit/01effb8484723af55905ecab2a95b85e6b23fb48).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-820133395
oh yeah to retrigger the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32107:
URL: https://github.com/apache/spark/pull/32107#issuecomment-821951025
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42103/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #32107: [SPARK-34716][SQL] Support ANSI SQL intervals by the aggregate function `sum`
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #32107:
URL: https://github.com/apache/spark/pull/32107#discussion_r612079585
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
##########
@@ -1110,6 +1112,14 @@ class DataFrameAggregateSuite extends QueryTest
val e = intercept[AnalysisException](arrayDF.groupBy(struct($"col.a")).count())
assert(e.message.contains("requires integral type"))
}
+
+ test("SPARK-34716: Support ANSI SQL intervals by the aggregate function `sum`") {
+ val df = Seq((Period.ofMonths(10), Duration.ofDays(10)),
+ (Period.ofMonths(1), Duration.ofDays(1)))
+ .toDF("year-month", "day-time")
+ val sumDF = df.select(sum($"year-month"), sum($"day-time"))
+ checkAnswer(sumDF, Row(Period.ofMonths(11), Duration.ofDays(11)))
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org