You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/07/14 19:50:19 UTC
Review Request 23455: Add a lightweight version of command hooks for
clientv1 commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Kevin Sweeney.
Bugs: aurora-581
https://issues.apache.org/jira/browse/aurora-581
Repository: aurora
Description
-------
Add a lightweight version of command hooks for clientv1 commands.
Diffs
-----
src/main/python/apache/aurora/client/commands/core.py 0939f0570572375ba9b4d054ddb9849995c9048d
src/test/python/apache/aurora/client/commands/test_kill.py 94bbe1bfff1c8d333837aa6bb14700714f46288b
Diff: https://reviews.apache.org/r/23455/diff/
Testing
-------
Added new unit tests, and ran full unit test suite.
Thanks,
Mark Chu-Carroll
Re: Review Request 23455: Add a lightweight version of command hooks for
clientv1 commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/
-----------------------------------------------------------
(Updated July 22, 2014, 10:49 a.m.)
Review request for Aurora, Joe Smith and Kevin Sweeney.
Changes
-------
Rebase.
Bugs: aurora-581
https://issues.apache.org/jira/browse/aurora-581
Repository: aurora
Description
-------
Add a lightweight version of command hooks for clientv1 commands.
Diffs (updated)
-----
src/main/python/apache/aurora/client/commands/core.py cbda8a93c3abbf9c0e8d2d9d64dddabe8a4b164e
src/test/python/apache/aurora/client/commands/test_kill.py d8d54a2b5ab31091ab43784e4311321dd06817c3
Diff: https://reviews.apache.org/r/23455/diff/
Testing
-------
Added new unit tests, and ran full unit test suite.
Thanks,
Mark Chu-Carroll
Re: Review Request 23455: Add a lightweight version of command hooks for
clientv1 commands.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/#review48075
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On July 14, 2014, 10:50 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23455/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 10:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: aurora-581
> https://issues.apache.org/jira/browse/aurora-581
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a lightweight version of command hooks for clientv1 commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 0939f0570572375ba9b4d054ddb9849995c9048d
> src/test/python/apache/aurora/client/commands/test_kill.py 94bbe1bfff1c8d333837aa6bb14700714f46288b
>
> Diff: https://reviews.apache.org/r/23455/diff/
>
>
> Testing
> -------
>
> Added new unit tests, and ran full unit test suite.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 23455: Add a lightweight version of command hooks for
clientv1 commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/#review48156
-----------------------------------------------------------
Kevin, ping? This has been sitting for days!
- Mark Chu-Carroll
On July 14, 2014, 1:50 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23455/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 1:50 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: aurora-581
> https://issues.apache.org/jira/browse/aurora-581
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a lightweight version of command hooks for clientv1 commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 0939f0570572375ba9b4d054ddb9849995c9048d
> src/test/python/apache/aurora/client/commands/test_kill.py 94bbe1bfff1c8d333837aa6bb14700714f46288b
>
> Diff: https://reviews.apache.org/r/23455/diff/
>
>
> Testing
> -------
>
> Added new unit tests, and ran full unit test suite.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 23455: Add a lightweight version of command hooks for
clientv1 commands.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/#review48068
-----------------------------------------------------------
Ship it!
Ship It!
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/23455/#comment84347>
Can safely omit this
- Kevin Sweeney
On July 14, 2014, 10:50 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23455/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 10:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: aurora-581
> https://issues.apache.org/jira/browse/aurora-581
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a lightweight version of command hooks for clientv1 commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 0939f0570572375ba9b4d054ddb9849995c9048d
> src/test/python/apache/aurora/client/commands/test_kill.py 94bbe1bfff1c8d333837aa6bb14700714f46288b
>
> Diff: https://reviews.apache.org/r/23455/diff/
>
>
> Testing
> -------
>
> Added new unit tests, and ran full unit test suite.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 23455: Add a lightweight version of command hooks for
clientv1 commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/#review48362
-----------------------------------------------------------
src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/23455/#comment84911>
Yeah, I know - but I think that it's clearer. Probably just me, but I find that skimming code, I look for something in the body of a function, and I misread subsequent code as being nested functions if the explicit pass is omitted.
- Mark Chu-Carroll
On July 14, 2014, 1:50 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23455/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 1:50 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: aurora-581
> https://issues.apache.org/jira/browse/aurora-581
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a lightweight version of command hooks for clientv1 commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/commands/core.py 0939f0570572375ba9b4d054ddb9849995c9048d
> src/test/python/apache/aurora/client/commands/test_kill.py 94bbe1bfff1c8d333837aa6bb14700714f46288b
>
> Diff: https://reviews.apache.org/r/23455/diff/
>
>
> Testing
> -------
>
> Added new unit tests, and ran full unit test suite.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>