You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/12 16:42:22 UTC

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5054: [Bugfix][IR][ATTRS] Fix AttrEqual for Array and StrMap, double

MarisaKirisame commented on a change in pull request #5054: [Bugfix][IR][ATTRS] Fix AttrEqual for Array and StrMap, double
URL: https://github.com/apache/incubator-tvm/pull/5054#discussion_r391749990
 
 

 ##########
 File path: src/printer/doc.cc
 ##########
 @@ -54,6 +51,9 @@ TVM_REGISTER_OBJECT_TYPE(DocTextNode);
 class DocText : public DocAtom {
  public:
   explicit DocText(std::string str) {
+    if (str.find_first_of("\t\n") != str.npos) {
+      LOG(WARNING) << "text node: '" << str << "' should not has tab or newline.";
 
 Review comment:
   ```suggestion
         LOG(WARNING) << "text: '" << str << "' should not has tab or newline.";
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services