You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/27 08:53:02 UTC

[GitHub] [submarine] Kenchu123 opened a new pull request #727: SUBMARINE-999. Make the submarine related storage class into one single storage class

Kenchu123 opened a new pull request #727:
URL: https://github.com/apache/submarine/pull/727


   ### What is this PR for?
   <!-- A few sentences describing the overall goals of the pull request's commits.
   First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
   -->
   
   There are five storage class in helm charts for submarine (server, database, tensorboard, mlflow, minio, notebook).
   
   However, they all have the same configurations, so we can just use one storage class instead.
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   
   
   ### What is the Jira issue?
   <!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
   * Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
   -->
   
   https://issues.apache.org/jira/browse/SUBMARINE-999
   
   ### How should this be tested?
   <!--
   * First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   -->
   
   1. Install submarine operator
   2. Add a submarine custom resource
   3. Create a notebook from the workbench
   
   You can find out that everything works fine. 
   
   ### Screenshots (if appropriate)
   
   The only storage class:
   
   <img width="803" alt="Screen Shot 2021-08-27 at 4 51 59 PM" src="https://user-images.githubusercontent.com/17617373/131100653-b68202d2-6574-4b68-b0c5-a1b22e511482.png">
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] Kenchu123 closed pull request #727: SUBMARINE-999. Make the submarine related storage class into one single storage class

Posted by GitBox <gi...@apache.org>.
Kenchu123 closed pull request #727:
URL: https://github.com/apache/submarine/pull/727


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] asfgit closed pull request #727: SUBMARINE-999. Make the submarine related storage class into one single storage class

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #727:
URL: https://github.com/apache/submarine/pull/727


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] Kenchu123 closed pull request #727: SUBMARINE-999. Make the submarine related storage class into one single storage class

Posted by GitBox <gi...@apache.org>.
Kenchu123 closed pull request #727:
URL: https://github.com/apache/submarine/pull/727


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org