[jira] [Created] (JCLOUDS-384) Trove and Autoscale method names need to be consistent

["Zack Shoylev (JIRA)" <ji...@apache.org>]

Zack Shoylev created JCLOUDS-384:
------------------------------------

             Summary: Trove and Autoscale method names need to be consistent
                 Key: JCLOUDS-384
                 URL: https://issues.apache.org/jira/browse/JCLOUDS-384
             Project: jclouds
          Issue Type: Bug
          Components: jclouds-labs-openstack
            Reporter: Zack Shoylev
            Assignee: Zack Shoylev
             Fix For: 1.7.0


As Everett pointed out:

In TroveApi you have the methods:

   FlavorApi getFlavorApiForZone(
         @EndpointParam(parser = ZoneToEndpoint.class) @Nullable String zone);
   
   InstanceApi getInstanceApiForZone(
         @EndpointParam(parser = ZoneToEndpoint.class) @Nullable String zone);
   
   @Path("/instances/{instanceId}")
   UserApi getUserApiForInstanceInZone(@PathParam("instanceId") String instanceId, 
         @EndpointParam(parser = ZoneToEndpoint.class) @Nullable String zone);
   
   @Path("/instances/{instanceId}")
   DatabaseApi getDatabaseApiForInstanceInZone(@PathParam("instanceId") String instanceId, 
         @EndpointParam(parser = ZoneToEndpoint.class) @Nullable String zone);

Then look at the methods where there is a similar second param like MarconiApi or CloudLoadBalancersApi.

The methods are always named with For in the name (e.g. getWhateverApiForZoneAndSomething()). 

Also the zone param always comes first. This is common practice when writing method signatures that have the same param in a lot of methods, that param should appear in the same position.
--

Note: backwards incompatible change.



--
This message was sent by Atlassian JIRA
(v6.1#6144)