You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "usbrandon (via GitHub)" <gi...@apache.org> on 2023/04/28 19:04:18 UTC
[GitHub] [hop] usbrandon opened a new issue, #2886: [Bug]: Text Input (Content Tab) - Limit option (Off by one?)
usbrandon opened a new issue, #2886:
URL: https://github.com/apache/hop/issues/2886
### Apache Hop version?
2.4-GA
### Java version?
11
### Operating system
Linux
### What happened?
I wanted only to output the first two rows in my CSV file. When I put 2 in the box, only 1 row came out. When I entered 3, the 2 rows I desired came out. That feels wrong. Is this a bug?
### Issue Priority
Priority: 3
### Issue Component
Component: Transforms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on issue #2886: [Bug]: Text Input (Content Tab) - Limit option (Off by one?)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #2886:
URL: https://github.com/apache/hop/issues/2886#issuecomment-1528733080
My guess is that the header is also counted as a written line, so you end up with header (your header is set to 1 line) + 2 data rows if you put limit 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] bjackson-ep commented on issue #2886: [Bug]: Text Input (Content Tab) - Limit option (Off by one?)
Posted by "bjackson-ep (via GitHub)" <gi...@apache.org>.
bjackson-ep commented on issue #2886:
URL: https://github.com/apache/hop/issues/2886#issuecomment-1546794913
What if we could signal to the user that they should upgrade options in a transform and record in the pipeline some version number where we know certain things are improved? Or... what if we have a pipeline / workflow scanner that could be a "are you ready for an upgrade?" tool and let it optionally update things like this. You know it would only be something like -1 to what they had.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] usbrandon commented on issue #2886: [Bug]: Text Input (Content Tab) - Limit option (Off by one?)
Posted by "usbrandon (via GitHub)" <gi...@apache.org>.
usbrandon commented on issue #2886:
URL: https://github.com/apache/hop/issues/2886#issuecomment-1537124831
Yes, I would agree with updating any hint or description near that label. It is not logical to even consider it the way that it is. It is an "Input" and cannot even possibly output a "header row" as part of the normal output that one would consider limiting in the first place. So now that it is baked in, we have to prevent people from making mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] bamaer commented on issue #2886: [Bug]: Text Input (Content Tab) - Limit option (Off by one?)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on issue #2886:
URL: https://github.com/apache/hop/issues/2886#issuecomment-1537122461
made the same assumption, which seems to be [correct](https://github.com/apache/hop/blob/81c3484bf69bdfb867dd76a3013ed5194f4497b8/plugins/transforms/textfile/src/main/java/org/apache/hop/pipeline/transforms/fileinput/text/TextFileInputReader.java#L398)
backward compatibility issues are probably extremely limited in number, but not 0, so the safest approach seems to me to update the description and docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org