[jira] [Resolved] (ARROW-17686) [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind errors

["Antoine Pitrou (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Pitrou resolved ARROW-17686.
------------------------------------
    Fix Version/s: 10.0.0
       Resolution: Fixed

Issue resolved by pull request 14172
[https://github.com/apache/arrow/pull/14172]

> [C++] AsofJoinBasicParams has no gtest printer defined, leading to valgrind errors
> ----------------------------------------------------------------------------------
>
>                 Key: ARROW-17686
>                 URL: https://issues.apache.org/jira/browse/ARROW-17686
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Weston Pace
>            Assignee: Percy Camilo Triveño Aucahuasi
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 10.0.0
>
>         Attachments: valgrind.txt
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Valgrind is currently failing on arrow-compute-asof-join-node-test: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=34147&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=4118
> The issue appears to be that AsofJoinBasicParams has no gtest printer and so gtest is using the default universal-printer which doesn't really play well with valgrind.  We should add a custom PrintTo method for AsofJoinBasicParams per: https://github.com/google/googletest/blob/main/googletest/include/gtest/gtest-printers.h



--
This message was sent by Atlassian Jira
(v8.20.10#820010)