You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/08/07 23:25:54 UTC
Review Request 13388: (Stout) Changed proc::status(pid) to use os::read()
instead of ifstream because it threw unexpected exceptions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13388/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-534
https://issues.apache.org/jira/browse/MESOS-534
Repository: mesos-git
Description
-------
See summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp d51aaa97e90377c7ee0f3c68af4be295ce5f70f8
Diff: https://reviews.apache.org/r/13388/diff/
Testing
-------
sudo ./bin/mesos-tests.sh -j --gtest_filter="ReaperTest.*" --gtest_repeat=15000 --gtest_break_on_failure --gtest_shuffle
Thanks,
Jiang Yan Xu
Re: Review Request 13388: (Stout) Changed proc::status(pid) to use
os::read() instead of ifstream because it threw unexpected exceptions.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13388/#review24835
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp
<https://reviews.apache.org/r/13388/#comment48995>
s/file_/read/
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp
<https://reviews.apache.org/r/13388/#comment48996>
s/file(/data(/
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp
<https://reviews.apache.org/r/13388/#comment48997>
s/file/data/
- Benjamin Hindman
On Aug. 7, 2013, 9:25 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13388/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 9:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-534
> https://issues.apache.org/jira/browse/MESOS-534
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp d51aaa97e90377c7ee0f3c68af4be295ce5f70f8
>
> Diff: https://reviews.apache.org/r/13388/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh -j --gtest_filter="ReaperTest.*" --gtest_repeat=15000 --gtest_break_on_failure --gtest_shuffle
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 13388: (Stout) Changed proc::status(pid) to use
os::read() instead of ifstream because it threw unexpected exceptions.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13388/
-----------------------------------------------------------
(Updated Aug. 9, 2013, 9:50 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Comments.
Bugs: MESOS-534
https://issues.apache.org/jira/browse/MESOS-534
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp d51aaa97e90377c7ee0f3c68af4be295ce5f70f8
Diff: https://reviews.apache.org/r/13388/diff/
Testing
-------
sudo ./bin/mesos-tests.sh -j --gtest_filter="ReaperTest.*" --gtest_repeat=15000 --gtest_break_on_failure --gtest_shuffle
Thanks,
Jiang Yan Xu
Re: Review Request 13388: (Stout) Changed proc::status(pid) to use
os::read() instead of ifstream because it threw unexpected exceptions.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13388/#review24937
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp
<https://reviews.apache.org/r/13388/#comment49097>
This is also now for istringstream
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp
<https://reviews.apache.org/r/13388/#comment49096>
s/stringstream/istringstream/ since we only need input?
- Ben Mahler
On Aug. 9, 2013, 3:14 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13388/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 3:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-534
> https://issues.apache.org/jira/browse/MESOS-534
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp d51aaa97e90377c7ee0f3c68af4be295ce5f70f8
>
> Diff: https://reviews.apache.org/r/13388/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh -j --gtest_filter="ReaperTest.*" --gtest_repeat=15000 --gtest_break_on_failure --gtest_shuffle
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 13388: (Stout) Changed proc::status(pid) to use
os::read() instead of ifstream because it threw unexpected exceptions.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13388/
-----------------------------------------------------------
(Updated Aug. 9, 2013, 3:14 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Addressed comments.
Bugs: MESOS-534
https://issues.apache.org/jira/browse/MESOS-534
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp d51aaa97e90377c7ee0f3c68af4be295ce5f70f8
Diff: https://reviews.apache.org/r/13388/diff/
Testing
-------
sudo ./bin/mesos-tests.sh -j --gtest_filter="ReaperTest.*" --gtest_repeat=15000 --gtest_break_on_failure --gtest_shuffle
Thanks,
Jiang Yan Xu