You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/04/02 15:53:41 UTC
Review Request: CLOUDSTACK-1830: ZWPS: NPE while create volume from snapshot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10239/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Description
-------
CLOUDSTACK-1830: ZWPS: NPE while create volume from snapshot
previously there is a check for hypervisor type using the virtual machine profile where null is being passes.
Changed the check by getting the hypervisor type from the disk profile.
This addresses bug CLOUDSTACK-1830.
Diffs
-----
engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java c45f8a8
Diff: https://reviews.apache.org/r/10239/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-1830: ZWPS: NPE while create volume from
snapshot
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10239/#review18614
-----------------------------------------------------------
Commit 6110e00c549630e8b08fc6ca4818a60ef6a0c919 in branch refs/heads/master from Edison Su <su...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6110e00 ]
CLOUDSTACK-1830: ZWPS: NPE while create volume from snapshot
- ASF Subversion and Git Services
On April 2, 2013, 1:53 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10239/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 1:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> CLOUDSTACK-1830: ZWPS: NPE while create volume from snapshot
>
> previously there is a check for hypervisor type using the virtual machine profile where null is being passes.
> Changed the check by getting the hypervisor type from the disk profile.
>
>
> This addresses bug CLOUDSTACK-1830.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java c45f8a8
>
> Diff: https://reviews.apache.org/r/10239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-1830: ZWPS: NPE while create volume from
snapshot
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10239/#review18615
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On April 2, 2013, 1:53 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10239/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 1:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> CLOUDSTACK-1830: ZWPS: NPE while create volume from snapshot
>
> previously there is a check for hypervisor type using the virtual machine profile where null is being passes.
> Changed the check by getting the hypervisor type from the disk profile.
>
>
> This addresses bug CLOUDSTACK-1830.
>
>
> Diffs
> -----
>
> engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java c45f8a8
>
> Diff: https://reviews.apache.org/r/10239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>