You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by et...@apache.org on 2008/09/25 20:44:10 UTC
svn commit: r699049 - in /incubator/shindig/trunk/java/gadgets/src:
main/java/org/apache/shindig/gadgets/render/
test/java/org/apache/shindig/gadgets/render/
Author: etnu
Date: Thu Sep 25 11:44:09 2008
New Revision: 699049
URL: http://svn.apache.org/viewvc?rev=699049&view=rev
Log:
Renamed RenderDispatcher to Renderer to complete split.
Added:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java
- copied, changed from r699010, incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderDispatcher.java
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java
- copied, changed from r699010, incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderDispatcherTest.java
Removed:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderDispatcher.java
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderDispatcherTest.java
Modified:
incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java
Copied: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java (from r699010, incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderDispatcher.java)
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java?p2=incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java&p1=incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderDispatcher.java&r1=699010&r2=699049&rev=699049&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderDispatcher.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java Thu Sep 25 11:44:09 2008
@@ -39,19 +39,17 @@
/**
* Validates a rendering request parameters before calling an appropriate renderer.
- *
- * TODO: Rename to Renderer
*/
-public class RenderDispatcher {
- private static final Logger LOG = Logger.getLogger(RenderDispatcher.class.getName());
+public class Renderer {
+ private static final Logger LOG = Logger.getLogger(Renderer.class.getName());
private final HtmlRenderer renderer;
private final GadgetSpecFactory gadgetSpecFactory;
private final ContainerConfig containerConfig;
@Inject
- public RenderDispatcher(HtmlRenderer renderer,
- GadgetSpecFactory gadgetSpecFactory,
- ContainerConfig containerConfig) {
+ public Renderer(HtmlRenderer renderer,
+ GadgetSpecFactory gadgetSpecFactory,
+ ContainerConfig containerConfig) {
this.renderer = renderer;
this.gadgetSpecFactory = gadgetSpecFactory;
this.containerConfig = containerConfig;
Modified: incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java?rev=699049&r1=699048&r2=699049&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java Thu Sep 25 11:44:09 2008
@@ -45,7 +45,7 @@
import java.util.Map;
/**
- * Tests for Renderer
+ * Tests for HtmlRenderer
*/
public class HtmlRendererTest {
private static final Uri SPEC_URL = Uri.parse("http://example.org/gadget.xml");
Copied: incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java (from r699010, incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderDispatcherTest.java)
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java?p2=incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java&p1=incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderDispatcherTest.java&r1=699010&r2=699049&rev=699049&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderDispatcherTest.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java Thu Sep 25 11:44:09 2008
@@ -39,9 +39,9 @@
import java.util.Arrays;
/**
- * Tests for RenderDispatcher.
+ * Tests for Renderer.
*/
-public class RenderDispatcherTest {
+public class RendererTest {
private static final Uri SPEC_URL = Uri.parse("http://example.org/gadget.xml");
private static final Uri TYPE_URL_HREF = Uri.parse("http://example.org/gadget.php");
private static final String BASIC_HTML_CONTENT = "Hello, World!";
@@ -56,12 +56,12 @@
private final FakeHtmlRenderer htmlRenderer = new FakeHtmlRenderer();
private final FakeGadgetSpecFactory gadgetSpecFactory = new FakeGadgetSpecFactory();
private FakeContainerConfig containerConfig;
- private RenderDispatcher renderer;
+ private Renderer renderer;
@Before
public void setUp() throws Exception {
containerConfig = new FakeContainerConfig();
- renderer = new RenderDispatcher(htmlRenderer, gadgetSpecFactory, containerConfig);
+ renderer = new Renderer(htmlRenderer, gadgetSpecFactory, containerConfig);
}
private GadgetContext makeContext(final String view, final Uri specUrl) {