[GitHub] [spark] majdyz commented on a diff in pull request #42394: [SPARK-44718][SQL] Match ColumnVector memory-mode config default to OffHeapMemoryMode config value

["majdyz (via GitHub)" <gi...@apache.org>]

majdyz commented on code in PR #42394:
URL: https://github.com/apache/spark/pull/42394#discussion_r1288131178


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -502,10 +502,14 @@ object SQLConf {
   val COLUMN_VECTOR_OFFHEAP_ENABLED =
     buildConf("spark.sql.columnVector.offheap.enabled")
       .internal()
-      .doc("When true, use OffHeapColumnVector in ColumnarBatch.")
+      .doc("When true, use OffHeapColumnVector in ColumnarBatch. " +
+        s"Defaults to $MEMORY_OFFHEAP_ENABLED && $MEMORY_OFFHEAP_SIZE > 0.")
       .version("2.3.0")
       .booleanConf
-      .createWithDefault(false)
+      .createWithDefaultFunction(() => {

Review Comment:
   Updated. But now the off-heap size check is removed, I hope it's fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org