You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/12 07:02:49 UTC

[GitHub] [rocketmq-apis] lizhanhui commented on a diff in pull request #57: Remove RecoverOrphanedTransactionCommand#message_queue

lizhanhui commented on code in PR #57:
URL: https://github.com/apache/rocketmq-apis/pull/57#discussion_r918616249


##########
apache/rocketmq/v2/service.proto:
##########
@@ -183,9 +183,8 @@ message VerifyMessageResult {
 }
 
 message RecoverOrphanedTransactionCommand {
-  MessageQueue message_queue = 1;
-  Message orphaned_transactional_message = 2;
-  string transaction_id = 3;
+  Message orphaned_transactional_message = 1;

Review Comment:
   Rename orphaned_transactional_message -> message as it's already wrapped in the structure of OrphanTransactionCommand



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org