You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/17 01:41:15 UTC

[GitHub] [pulsar] zhaoyajun2009 opened a new pull request, #16102: Modify the broker.conf with bundle number

zhaoyajun2009 opened a new pull request, #16102:
URL: https://github.com/apache/pulsar/pull/16102

   
   
   ### Motivation
   
   
   Many community partners have doubts and misunderstandings about this parameter, so the modification is more clear
   
   ### Modifications
   1）modify the description
   # When a namespace is created without specifying the number of bundle, this
   # value will be used as the default，the maximum number of namespaces is 2147483648.
   defaultNumberOfNamespaceBundles=4
   
   
   2）modify the description
   # maximum number of bundles in a namespace when loadBalance triggers bundle auto split
   loadBalancerNamespaceMaximumBundles=128
   
   ### Verifying this change
   no
   
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zhaoyajun2009 commented on a diff in pull request #16102: Modify the broker.conf with bundle number

Posted by GitBox <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #16102:
URL: https://github.com/apache/pulsar/pull/16102#discussion_r941915001


##########
conf/broker.conf:
##########
@@ -258,7 +258,7 @@ brokerDeduplicationEntriesInterval=1000
 brokerDeduplicationProducerInactivityTimeoutMinutes=360
 
 # When a namespace is created without specifying the number of bundle, this
-# value will be used as the default
+# value will be used as the default，the maximum number of namespaces is 2147483648.

Review Comment:
   @hangc0276 please take a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on a diff in pull request #16102: Modify the broker.conf with bundle number

Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #16102:
URL: https://github.com/apache/pulsar/pull/16102#discussion_r899695628


##########
conf/broker.conf:
##########
@@ -258,7 +258,7 @@ brokerDeduplicationEntriesInterval=1000
 brokerDeduplicationProducerInactivityTimeoutMinutes=360
 
 # When a namespace is created without specifying the number of bundle, this
-# value will be used as the default
+# value will be used as the default，the maximum number of namespaces is 2147483648.

Review Comment:
   Does this `2147483648` actually works for bundle number? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zhaoyajun2009 commented on a diff in pull request #16102: Modify the broker.conf with bundle number

Posted by GitBox <gi...@apache.org>.
zhaoyajun2009 commented on code in PR #16102:
URL: https://github.com/apache/pulsar/pull/16102#discussion_r899776029


##########
conf/broker.conf:
##########
@@ -258,7 +258,7 @@ brokerDeduplicationEntriesInterval=1000
 brokerDeduplicationProducerInactivityTimeoutMinutes=360
 
 # When a namespace is created without specifying the number of bundle, this
-# value will be used as the default
+# value will be used as the default，the maximum number of namespaces is 2147483648.

Review Comment:
   theoretically，not actually



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16102: Modify the broker.conf with bundle number

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16102:
URL: https://github.com/apache/pulsar/pull/16102#issuecomment-1190958593

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on a diff in pull request #16102: Modify the broker.conf with bundle number

Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #16102:
URL: https://github.com/apache/pulsar/pull/16102#discussion_r900688877


##########
conf/broker.conf:
##########
@@ -258,7 +258,7 @@ brokerDeduplicationEntriesInterval=1000
 brokerDeduplicationProducerInactivityTimeoutMinutes=360
 
 # When a namespace is created without specifying the number of bundle, this
-# value will be used as the default
+# value will be used as the default，the maximum number of namespaces is 2147483648.

Review Comment:
   So this info is misleading. What about like "int type, maximum number depends on metadata performance, normally not larger than ???"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org